Closed
Bug 1586487
Opened 5 years ago
Closed 5 years ago
"Change…" button label is hard-coded
Categories
(Firefox :: Sync, defect, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | unaffected |
| firefox70 | --- | unaffected |
| firefox71 | + | fixed |
People
(Reporter: flod, Assigned: eoger)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
<button id="syncChangeOptions"
label="Change…"
is="highlightable-button"/>
It would be great to use pseudolocales when testing patches involving Fluent bits, this would immediately stands out
https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.html#pseudolocalization
|
Reporter | |
Updated•5 years ago
|
Component: Firefox Accounts → Preferences
|
||
Comment 1•5 years ago
|
||
[Tracking Requested - why for this release]:
Shouldn't ship hardcoded English.
I wonder if we could write an HTML/XUL linter for this kind of thing... Clearly, a patch author and 3 not-exactly-inexperienced reviewers missed this, so some automation might help.
status-firefox68:
--- → unaffected
status-firefox69:
--- → unaffected
status-firefox70:
--- → unaffected
status-firefox71:
--- → affected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
tracking-firefox71:
--- → ?
Keywords: regression
Priority: -- → P1
Regressed by: 1570567
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → eoger
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•5 years ago
|
Component: Preferences → Sync
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4719f626670
Make "Change…" button localizable. r=flod,fluent-reviewers
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
|
||
Updated•5 years ago
|
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•