Closed Bug 1586487 Opened 4 months ago Closed 4 months ago

"Change…" button label is hard-coded

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 + fixed

People

(Reporter: flod, Assigned: eoger)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/2f29d53865cb895bf16c91336cc575aecd996a17/browser/components/preferences/in-content/sync.inc.xul#237

<button id="syncChangeOptions"
    label="Change…"
    is="highlightable-button"/>

It would be great to use pseudolocales when testing patches involving Fluent bits, this would immediately stands out
https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.html#pseudolocalization

Component: Firefox Accounts → Preferences

[Tracking Requested - why for this release]:
Shouldn't ship hardcoded English.

I wonder if we could write an HTML/XUL linter for this kind of thing... Clearly, a patch author and 3 not-exactly-inexperienced reviewers missed this, so some automation might help.

Assignee: nobody → eoger
Status: NEW → ASSIGNED
Component: Preferences → Sync
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4719f626670
Make "Change…" button localizable. r=flod,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.