Closed Bug 1586574 Opened 5 years ago Closed 2 years ago

apply horizontal writing mode to mathml elements

Categories

(Core :: MathML, defect)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1095933 +++

Eventually, it'd probably be ideal to make MathML content in vertical writing mode work "correctly", by rendering it as if with text-orientation:sideways-right. But that will require logicalizing a whole bunch of mathml layout classes so that all the x/y positioning behaves in the appropriately rotated way.

Until we're ready to tackle that, let's simply make all mathml have writing-mode:horizontal-tb by putting this in the UA stylesheet.

In bug 1095933, horizontal mode is only forced on the <math> root.

https://w3c-test.org/mathml/relations/css-styling/ignored-properties-001.html shows that the property can still be set to change the MathML layout.

Let's force horizontal-tb on all MathML elements for now, as suggested by
https://mathml-refresh.github.io/mathml-core/#css-styling

Assignee: nobody → fwang
Status: NEW → ASSIGNED
Severity: normal → S3
Pushed by fred.wang@free.fr:
https://hg.mozilla.org/integration/autoland/rev/32522f6f6750
apply horizontal writing mode to mathml elements. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37519 for changes under testing/web-platform/tests
Pushed by sstanca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0333911e278
Backed out changeset 32522f6f6750 for causing wpt unexpected passes on reset-and-logicial-property.html. CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/06a17fd75d84
apply horizontal writing mode to mathml elements. r=emilio CLOSED TREE

Backed out for causing wpt failures in ignored-properties-001.html.

12-15 10:52:26.406 7616 7631 I Gecko : [Child 7616, Main Thread] ###!!! ASSERTION: How'd we get a floated inline frame? The frame ctor should've dealt with this.: '!aReflowInput.mStyleDisplay->IsFloating(aReflowInput.mFrame)', file /builds/worker/checkouts/gecko/layout/generic/nsLineLayout.cpp:1092

https://firefoxci.taskcluster-artifacts.net/GirrS6meQfi9Q0Yc-F0jcw/0/public/test_info/logcat-emulator-5554.log

Flags: needinfo?(fwang)
Upstream PR was closed without merging

OK, it seems existing .ini has max-asserts: 51 we should probably keep that until we can do something similar to https://chromium-review.googlesource.com/c/chromium/src/+/4055563

Flags: needinfo?(fwang)
Pushed by fred.wang@free.fr:
https://hg.mozilla.org/integration/autoland/rev/112934bd11d2
apply horizontal writing mode to mathml elements. r=emilio

Backed out for causing reftest failures on 1748277.html

Backout link

Push with failures

Failure log

Flags: needinfo?(fwang)
Upstream PR was closed without merging

Forcing horizontal-tb seems to fix the assert for bug 1751260 / bug 1751713 ; so we need to tweak the expectation.

I resent a try job in debug to be sure we don't have more changes: https://treeherder.mozilla.org/jobs?repo=try&revision=f4b6d5df59c5963338911edcfd8f3633b9fc2eda

Flags: needinfo?(fwang)
Pushed by fred.wang@free.fr:
https://hg.mozilla.org/integration/autoland/rev/c3b29f5e7581
apply horizontal writing mode to mathml elements. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: