1586590 - 'Delete this login?': buttons 'Delete' and 'Cancel' don't have same distance to borders (mirror each other) if text above is longer due to localization

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of issue (German)

Firefox 71.0a1 20191005214618 and 70.0b12 on Windows 8.1

If a login shall we deleted on about:logins, a prompt is shown. Its buttons to confirm or cancel the action should have the same distance to the vertical borders but don't have it if the text above is longer (due to localization). See the attached screenshot for German.

Steps to reproduce:
0. Use Firefox in German, or follow the steps below.

1. Open Firefox's Options, e.g. from the button with the 3 horizontal bars.
2. Go to 'Privacy & Security'.
3. Scroll down to 'Logins and Passwords'.
4. Click 'Saved Logins'.
5. Add a new (fake) login (bottom left).
6. After the login got added, click the 'Delete' button (top right).
7. If you use Firefox in English, press Ctrl+Shift+C to open the Inspector.
8. With the left most button in the developer toolbar active, click on the text above the buttons 'Delete' and 'Cancel'.
9. In the Inspector, double-click 'This action cannot be undone.'
10. Change the text to anything longer, e.g. 'This action cannot be undone. Make it longer for testing.'

Actual result: Buttons left aligned.
Expected result: Buttons justified or similar, should have the same distance to the vertical borders

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1586590 - Remaining space should be placed between the confirm and cancel buttons. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f0302585dae
Remaining space should be placed between the confirm and cancel buttons. r=MattN

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3f0302585dae

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift request before Monday's RC build?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

no, we're going to hold this for 71.

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 72.0a1 (Build ID: 20191021215155) and on the Firefox Beta 71.0b3 (Build ID: 20191021164841) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The “Delete” and “Cancel” buttons from the “Delete this login?” pop-up have the same distance between them if the text above in longer due to localization.