Closed Bug 1586592 Opened 2 years ago Closed 2 years ago

Perma js/xpconnect/tests/chrome/test_xrayToJS.xul | A property on the Promise constructor has changed! You need a security audit from an XPConnect peer - got "[\"all\", \"allSettled\", \"length\", \"name\", \"p when Gecko 71 merges to Beta on 2019-10-14

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 + verified

People

(Reporter: ccoroiu, Assigned: evilpie)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]:

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=269968814&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=28c494adb0d1bc3d7f6982e67b1fa6f7e1d36be4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269969886&repo=try&lineNumber=2718

task 2019-10-06T13:08:08.900Z] 13:08:08 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xrayed instances see proto expandos
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - Buffered messages finished
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xul | A property on the Promise constructor has changed! You need a security audit from an XPConnect peer - got "["all", "allSettled", "length", "name", "prototype", "race", "reject", "resolve"]", expected "["all", "length", "name", "prototype", "race", "reject", "resolve"]"
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:322:16
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:451:7
[task 2019-10-06T13:08:08.902Z] 13:08:08 INFO - testPromise@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:911:13
[task 2019-10-06T13:08:08.902Z] 13:08:08 INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:143:5
[task 2019-10-06T13:08:08.902Z] 13:08:08 INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:1:1

Flags: needinfo?(jorendorff)

Evilpies, maybe this is a regression from some of your recent work on array generics?

Flags: needinfo?(evilpies)

Actually caused by bug 1549176, but I just provided a patch anyway.

Assignee: nobody → evilpies
Flags: needinfo?(jorendorff)
Flags: needinfo?(evilpies)

Thanks! For some reason Bugzilla decided to collapse the "References" section so I didn't see the regression that was marked.

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9d9bdd86132c
Promise.allSettled is now enabled everywhere, fix test. r=jorendorff
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.