1586592 - Perma js/xpconnect/tests/chrome/test_xrayToJS.xul | A property on the Promise constructor has changed! You need a security audit from an XPConnect peer - got "[\"all\", \"allSettled\", \"length\", \"name\", \"p when Gecko 71 merges to Beta on 2019-10-14

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[Cristina Coroiu [:ccoroiu]]

[Tracking Requested - why for this release]:

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=269968814&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=28c494adb0d1bc3d7f6982e67b1fa6f7e1d36be4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269969886&repo=try&lineNumber=2718

task 2019-10-06T13:08:08.900Z] 13:08:08 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xul | Xrayed instances see proto expandos
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - Buffered messages finished
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xul | A property on the Promise constructor has changed! You need a security audit from an XPConnect peer - got "["all", "allSettled", "length", "name", "prototype", "race", "reject", "resolve"]", expected "["all", "length", "name", "prototype", "race", "reject", "resolve"]"
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:322:16
[task 2019-10-06T13:08:08.901Z] 13:08:08 INFO - testXray@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:451:7
[task 2019-10-06T13:08:08.902Z] 13:08:08 INFO - testPromise@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:911:13
[task 2019-10-06T13:08:08.902Z] 13:08:08 INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:143:5
[task 2019-10-06T13:08:08.902Z] 13:08:08 INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xul:1:1

Comment 1

[Andrew McCreight [:mccr8]]

Evilpies, maybe this is a regression from some of your recent work on array generics?

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1586592 - Promise.allSettled is now enabled everywhere, fix test. r?jorendorff

Comment 3

[Tom S [:evilpie]]

Actually caused by bug 1549176, but I just provided a patch anyway.

Comment 4

[Andrew McCreight [:mccr8]]

Thanks! For some reason Bugzilla decided to collapse the "References" section so I didn't see the regression that was marked.

Comment 5

[Andreea Pavel [:apavel]]

Patch works, failures are gone in recent beta simulations, just needs review to land: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=fbc64a86d5ef083dd2e88d999f119e1f9d07f0b0&searchStr=proc&selectedJob=270266544

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d9bdd86132c
Promise.allSettled is now enabled everywhere, fix test. r=jorendorff

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9d9bdd86132c

Comment 8

[Andreea Pavel [:apavel]]

Does not occur in beta sims anymore: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=bb2fcf3fbaadf65542cbd01b7cbb82a93f1a6bba&searchStr=mochitest-chrome&selectedJob=270666914