158660 - confirm_login in CGI.pl should use a template for the login dialog

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Tobias Burnus]

If one goes to query.cgi?GoAheadAndLogIn=1
confirm_login in CGI.pl is called which displays the login dialog.

This function should use a template for the rather common login dialog.

(bugzilla.org says to the 2.16 goals "Templatization of all customer-visible CGI
pages, to allow easy customization by the administrator." which is clearly not
met ...)

Comment 1

[Gervase Markham [:gerv]]

Yep, the login dialog should be templatised.

As to the goal being not met, you are possibly right. But the world can't wait
for all the other improvements that 2.16 brings any longer. Yesterday, I grepped
all the CGIs for "print" statements and, after eliminating false positives, came
up with a definitive list of places where templatisation is still necessary.
There are actually only a few. I then filed bugs on most of them - but not CGI.pl.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Templatisation of the login page.

(All the other non-templatised things in CGI.pl are to do with LDAP, and are
therefore not urgent.)

Gerv

Comment 3

[Jouni Heikniemi]

Is this 2.18, then? Tentatively marking so. And reviewing, in a moment. -> Gerv,
also. :-)

Comment 4

[Gervase Markham [:gerv]]

Absolutely. If I ask for review on anything, it's because it's 2.18, even if I
haven't marked it as such :-)

Gerv

Comment 5

[Jouni Heikniemi]

Comment on attachment 92467 [details] [diff] [review]
Patch v.1

>+[%# Allow the user to request a token to change their password (unless
>+  # we are using LDAP, in which case the user must use LDAP to change it).
>+  #%]

This comment not only applies to requesting change tokens, but also for
creating new accounts (a link for which is enclosed in the same UNLESS block).
Rewrite this comment to reflect the reality, and you've got 2xr=jouni.

Comment 6

[Gervase Markham [:gerv]]

Fixed.

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.163; previous revision: 1.162
done
RCS file:
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/login.html.tmpl,v
done
Checking in template/en/default/account/login.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/login.html.tmpl,v
 <--  login.html.tmpl
initial revision: 1.1
done

Gerv