1586603 - scratchpad deprecation message prevents selfxss warning from being shown to first time pasters

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

What were you doing?

Posting something into scratchpad for the first time in this new profile with Firefox 70.0b12 on Windows 8.1

Please tell us what site you were on, and what steps led to the error you are reporting

0. Use a new beta profile (Nightly will let you paste).
1. Copy some text
2. Press Shift+F4 to open Scratchpad
3. Try to paste.

What happened?

The deprecation notification bar got higher, the message why pasting didn't work is not shown (only after the deprecation message gets dismissed).

What should have happened?

Selfxss warning shown instead of the deprecation messing.

Comment 1

[Julian Descottes [:jdescottes]]

Assigning P3 for now, but let's ping :nchevobbe to see if this should have higher prio.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

P3 sounds good to me as we plan to deprecate Scratchpad soon.
Note that it seems that setting the deprecation warning as a medium one seems to work:

diff --git a/devtools/client/scratchpad/scratchpad.js b/devtools/client/scratchpad/scratchpad.js
--- a/devtools/client/scratchpad/scratchpad.js
+++ b/devtools/client/scratchpad/scratchpad.js
@@ -1781,7 +1781,7 @@ var Scratchpad = {
           deprecationFragment,
           "scratchpad.deprecated",
           null,
-          this.notificationBox.PRIORITY_WARNING_HIGH
+          this.notificationBox.PRIORITY_WARNING_MEDIUM
         );
 
         this.editor.on("change", this._onChanged);

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

meh, of course a test is now failing https://treeherder.mozilla.org/testview.html?repo=try&revision=42123badf07e98a213d676c744db35489efb51e1

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1586603 - Lower deprecation warning message priority. r=jdescottes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3916df0677f5
Lower deprecation warning message priority. r=jdescottes.

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3916df0677f5