Closed Bug 1586603 Opened 10 months ago Closed 10 months ago

scratchpad deprecation message prevents selfxss warning from being shown to first time pasters

Categories

(DevTools Graveyard :: Scratchpad, defect, P3)

defect

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 wontfix, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: aryx, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

What were you doing?

Posting something into scratchpad for the first time in this new profile with Firefox 70.0b12 on Windows 8.1

Please tell us what site you were on, and what steps led to the error you are reporting

  1. Use a new beta profile (Nightly will let you paste).
  2. Copy some text
  3. Press Shift+F4 to open Scratchpad
  4. Try to paste.

What happened?

The deprecation notification bar got higher, the message why pasting didn't work is not shown (only after the deprecation message gets dismissed).

What should have happened?

Selfxss warning shown instead of the deprecation messing.

Assigning P3 for now, but let's ping :nchevobbe to see if this should have higher prio.

Flags: needinfo?(nchevobbe)
Priority: -- → P3

P3 sounds good to me as we plan to deprecate Scratchpad soon.
Note that it seems that setting the deprecation warning as a medium one seems to work:

diff --git a/devtools/client/scratchpad/scratchpad.js b/devtools/client/scratchpad/scratchpad.js
--- a/devtools/client/scratchpad/scratchpad.js
+++ b/devtools/client/scratchpad/scratchpad.js
@@ -1781,7 +1781,7 @@ var Scratchpad = {
           deprecationFragment,
           "scratchpad.deprecated",
           null,
-          this.notificationBox.PRIORITY_WARNING_HIGH
+          this.notificationBox.PRIORITY_WARNING_MEDIUM
         );
 
         this.editor.on("change", this._onChanged);
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3916df0677f5
Lower deprecation warning message priority. r=jdescottes.
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Assignee: nobody → nchevobbe
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.