1586612 - Web Extension tabs.onUpdated event incorrectly fired before tabs.onCreated

Status: VERIFIED FIXED

(WebExtensions :: Compatibility, defect, P2)

Description

[Pauan]

Attachment: bug-report.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. Install the attached extension (bug-report.zip)
2. Open the extension debugging console
3. Open a new tab using Ctrl+T
4. Look at the debugging console

Actual results:

It logs the following (the id number will be different):

Updated 2137
Created 2137
Updated 2137

This is incorrect behavior (onCreated should always fire first), and it is not how Chrome behaves.

Expected results:

You should see these results:

Created 2137
Updated 2137
Updated 2137

Comment 1

[Pauan]

(This also affects the browser.tabs.onCreated and browser.tabs.onUpdated APIs, not just the chrome ones)

Comment 2

[Pablo]

I tested this and i was able to reproduce on all these Os and FF Versions:

Windows 10 64bit:
FF Nightly Release 71.0a1
FF Release 69.0.3
FF Beta 70.0

MacOs 10.14:
FF Nightly Release 71.0a1
FF Release 69.0.3
FF beta 70.0

Ubuntu 18.04:
FF Nightly Release 71.0a1
FF Release 69.0.3
FF Beta 70.0

Comment 3

[Pauan]

Thanks! But, shouldn't this be filed under the "Frontend" component? The issue is not with debugging, the issue is that the tabs API itself is working incorrectly.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1586612 properly handle tab events that happen prior to firing tabs.onCreated

Ensure that our delay in firing the onCreated (TabOpen) event does not result
in other events happening prior to onCreated.

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=00f587268ac31266a906d71bb6822a0006c6dbfb

Comment 7

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79bdf40de53c52b7105fde4c21c18b07fb6f6ae9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6c47672bcf7
properly handle tab events that happen prior to firing tabs.onCreated r=rpl,Gijs

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d6c47672bcf7

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 11

[Alex Cornestean]

Hello,

Verified the fix on the latest Nightly (73.0a1/20191215214948) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.

The tabs.onUpdated event will now be correctly fired after tabs.onCreated when opening a new tab, thus confirming the fix.