Open Bug 1586644 Opened 5 years ago Updated 2 years ago

[KDE] The title bar is present even when disabled in Customise (Linux)

Categories

(Core :: Widget: Gtk, defect, P2)

69 Branch
defect

Tracking

()

UNCONFIRMED

People

(Reporter: terauck, Assigned: stransky)

References

(Blocks 2 open bugs)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

  1. The title bar is present on Firefox 69.0.2 on a Linux (KDE) system.
  2. In menu selected 'Customise'.
  3. On Customise page looked at "Title Bar" option in bottom left corner; it is unchecked.
  4. I tried checking then unchecking the option to no avail, even when restarting Firefox.
  5. I tried using KDE's preferred GTK themes ('Breeze') on another KDE system, with no change.
  6. I restarted Firefox in "Safe Mode", with no change.
  7. I disabled stylesheets before restarting Firefox, again with no change.
  8. I tried two different profiles (one newly created), with no change.
  9. I have looked at Bug 1283299 but am unsure of its relevance.

Actual results:

The title bar continued to be present whether the "Title Bar" option in Customise is enabled or disabled regardless of the GTK theme used, the profile used and whether add-ons or stylesheets are enabled or not.

Expected results:

When the "Title Bar" is not enabled, the Title Bar should not be present. That was the result previously when using this profile. I don't know when that changed; I only recently noticed that the title bar is present.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Widget: Gtk
Product: Firefox → Core
Blocks: gtktitlebar
Priority: -- → P2

I installed Firefox Nightly and had the same issue. Noticed that my Manjaro installed stable Firefox 69.0 does not have this issue. Firefox stable was being ran with env GTK_CSD=0.

Running Firefox nightly with env GTK_CSD=0 solved this issue for me. IE the title bar is being correctly removed when running "env GTK_CSD=0 /opt/firefox-nightly/firefox"

Kind regards

Please try to run Firefox with MOZ_GTK_TITLEBAR_DECORATION=system and MOZ_GTK_TITLEBAR_DECORATION=client and check if the titlebar works for you. Also please run "env | grep XDG" command on console and attach an output here.
Thanks.

Flags: needinfo?(terauck-mozbugs)

With regard to the last comment, how do I "run Firefox with MOZ_GTK_TITLEBAR_DECORATION=system and MOZ_GTK_TITLEBAR_DECORATION=client". Do you want me to run the console command when I have done that, when I haven't done that or both? I assume I should execute it while Firefox is running.

Flags: needinfo?(terauck-mozbugs)

(In reply to watchman from comment #4)

With regard to the last comment, how do I "run Firefox with MOZ_GTK_TITLEBAR_DECORATION=system and MOZ_GTK_TITLEBAR_DECORATION=client". Do you want me to run the console command when I have done that, when I haven't done that or both? I assume I should execute it while Firefox is running.

Yes, use terminal for that. Close all your firefox instances, open terminal and run:

MOZ_GTK_TITLEBAR_DECORATION=system firefox

and when it quits run

MOZ_GTK_TITLEBAR_DECORATION=client firefox

Thanks.

Flags: needinfo?(terauck-mozbugs)

The title bar is still present when starting with either MOZ_GTK_TITLEBAR_DECORATION=system firefox or MOZ_GTK_TITLEBAR_DECORATION=client firefox. The terminal output for env | grep XDG is in each case
$ env | grep XDG
XDG_DATA_DIRS=/usr/local/share/:/usr/share/:/usr/share/gdm/
XDG_CURRENT_DESKTOP=KDE
XDG_RUNTIME_DIR=/var/run/user/1000
XDG_CONFIG_DIRS=/etc/xdg/discovery:/etc/xdg
XDG_SESSION_COOKIE=localhost.localdomain-1576686607.452492-343836777

I should perhaps mention that a solution on github worked for 10 days (i.e. no title bar) but I haven't been able to get it to work since then. Instead, I have been using a KDE "Window Rule" that enforces "No titlebar and frame".

Flags: needinfo?(terauck-mozbugs)
Summary: The title bar is present even when disabled in Customise (Linux) → [KDE] The title bar is present even when disabled in Customise (Linux)

We may need some more logging for it.

Can you please run firefox on terminal as:

MOZ_LOG="Widget:5" firefox > log.txt 2>&1

try to enable/disable titlebar at Customize and attach the log.txt file here?

Thanks.

Flags: needinfo?(terauck-mozbugs)

I did as you asked. I can see no way of attaching the file here so I have uploaded it and this is the link: https://www.mediafire.com/folder/vsp0kj3nju9y6/

Flags: needinfo?(terauck-mozbugs)

I see Firefox correctly use CSD_SUPPORT_CLIENT. Which exact distro do you run?

Flags: needinfo?(terauck-mozbugs)

The distro I run is PCLinuxOS. The Firefox rpm is built directly from the official build.

Flags: needinfo?(terauck-mozbugs)

I don't know what modifications has KDE on PCLinuxOS, but when I run KDE on Fedora the titlebar is correctly off although the browser itself looks ugty as it has a solid border around. So it looks like a some PCLinuxOS specific bug, but it's not caused by old Gtk version as the CSD mode is automatically selected at start.

I doubt that KDE is modified at all. I could enable and disable the titlebar for quite some time. I don't know when it became visible without being enabled but it must have been not long before I reported it. You can get rid of that border the same way as I get rid of the titlebar, with a KDE "Window Rule". The rule I use enforces "No titlebar and frame".

This started happening to me as well. I think it started on Beta 87b4? Nightly 88 shows the same issue.

Elementary OS, nVidia RTX 3070, 460.39.

Let me know if I should provide more info.

Ignore my previous comment, it was due to GTK_CSD=1 apparently being set by Elementary OS, though I'm not sure of it.

I can reproduce it on Elementary OS, GTK_CSD does not seem to be relevant.

Assignee: nobody → stransky
Severity: normal normal → S3 S3
You need to log in before you can comment on or make changes to this bug.