Closed Bug 1586651 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19541 - [LayoutNG] Fix line breaking when `font-size: 0`

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19541 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19541
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix line breaking when font-size: 0

This patch fixes line breaking when break opportunities have
font-size: 0.

font-size: 0 makes all characters at position 0. This
confuses when |NGLineBreaker| needs to rewind, and tries to
find the break opportunity before the current one.

This patch fixes it by using |PreviousBreakOpportunity| in
such case.

Bug: 1006127
Change-Id: I449d6f8aaba4deccd458c5e077920b1a8bf79305

Reviewed-on: https://chromium-review.googlesource.com/1843991
WPT-Export-Revision: a11487f9fb95dcf4ee52257aca3bd2cb1e58ecfc

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=89ede65470ee76e543d98425da9da96b7be1b82a&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=89ede65470ee76e543d98425da9da96b7be1b82a&label=pr_base)

Ran 1 tests

### Firefox
  PASS: 1

### Chrome
  FAIL: 1

### Safari
  PASS: 1

## Gecko CI Results

Ran 1 tests
  PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c276749f30a6
[wpt PR 19541] - [LayoutNG] Fix line breaking when `font-size: 0`, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c276749f30a6

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.