Closed Bug 1586674 Opened 10 months ago Closed 10 months ago

static inline uint32_t PRTimeToSeconds(PRTime aTimeUsec) can be simplified

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Just like in bug 1586605
http://sylvestre.ledru.info/reports/fx-scan-build/report-nsDocShell.h-PRTimeToSeconds-2-173.html#EndPath
Although the value stored to 'aTimeUsec' is used in the enclosing expression, the value is never actually read from 'aTimeUsec'

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec0f7787850e
Simplify 'static inline uint32_t PRTimeToSeconds(PRTime aTimeUsec)' r=valentin
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5de53dab979a
Simplify 'static inline uint32_t PRTimeToSeconds(PRTime aTimeUsec)' in CacheEntry.h too r=valentin
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → sledru
You need to log in before you can comment on or make changes to this bug.