1586680 - Fix devtools issues when toolbox uses a <browser> element instead of a content <iframe>

Status: RESOLVED FIXED

(DevTools :: General, task, P1)

Description

[Julian Descottes [:jdescottes]]

For Bug 1581925, the devtools toolbox will use a <browser> element instead of an <iframe> with type="content". For now, when devtools.toolbox.content-frame is set to false, we will still use an <iframe>, but this is being removed in Bug 1585747.

When applying the patches from Bug 1581925, there are a few issues:

• default html context menus appear when right clicking in HTML DevTools panels
• scroll-lock feature is enabled when doing middle click
• shift+F7 triggers the caret browsing popup instead of toggling the style editor

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1586680 - prevent default contextmenu events from DevTools html panels

With the removal of ContextMenuSpecialProcessChild.jsm in Bug 1581925, the default HTML context menu will start showing up when right clicking in empty areas of the HTML based DevTools panels.
The toolbox is will catch and stop all context menu events when they are coming from HTML documents.
For XUL panels, we still want context menu events to trigger their default behavior which we use to display custom context menus in those panels.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1586680 - prevent scroll lock from middle click events in DevTools toolbox

Depends on D48312

When the DevTools toolbox is using a <browser> element, middle click will start the scroll lock feature on macos and windows.
Catch all middleclick events from the toolbox and preventDefault to avoid this.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1586680 - Prevent showing caret browsing prompt when using StyleEditor shortcut

Depends on D48313

caret browsing is enabled by the F7 shortcut, and devtools style editor is toggled via shift+F7.
When the DevTools toolbox is using a browser element, using shift+F7 in the toolbox will first trigger caret browsing and then toggle the style-editor.
The DevTools shortcut is added via a XUL key in DevToolsStartup.jsm but I didn't manage to prevent the shift+F7 event from triggering the caret-browsing keypress callback.
So instead, check if shiftKey is true in the caret-browsing callback and bail out.
In theory, unless explicitly supported, the callback should bailout if any modifier is pressed.

Comment 4

[Julian Descottes [:jdescottes]]

try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=917921ae830847ec9a5e57419902f7f5c5dd23b3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d309560313a
prevent default contextmenu events from DevTools html panels r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/73deef02af0c
prevent scroll lock from middle click events in DevTools toolbox r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/fc5adc9d81ef
Prevent showing caret browsing prompt when using StyleEditor shortcut r=bgrins

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7d309560313a
https://hg.mozilla.org/mozilla-central/rev/73deef02af0c
https://hg.mozilla.org/mozilla-central/rev/fc5adc9d81ef