1586706 - Use QuoteString instead of StringToNewUTF8CharsZ when NUL characters are possible

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

https://phabricator.services.mozilla.com/D40067#inline-258336 proposed to use QuoteString instead of StringToNewUTF8CharsZ to properly handle resp. escape NUL characters. Because that suggestion not only applies to that patch, but actually to multiple other places, let's track it in a new bug.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1586706: Use QuoteString for JSString to char* conversion to ensure NUL characters don't cut off the result string. r=jwalden!

QuoteString always returns an ASCII string, so we can also change JS_ReportErrorNumberUTF8
to JS_ReportErrorNumberASCII in a few places.

Comment 2

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1086c9244116a32f938ae44200ed09c20af2e3e9

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d243ec1c977
Use QuoteString for JSString to char* conversion to ensure NUL characters don't cut off the result string. r=jwalden

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/6d243ec1c977