Make drag/drop nodes work with Fission
Categories
(DevTools :: Inspector, task, P1)
Tracking
(Fission Milestone:M4, firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: pbro, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-reserve)
Attachments
(1 file)
In the markup-view, you can drag and drop nodes to re-order the DOM. This feature will need fixing for it to work with Fission iframes.
Indeed, at least this line of code will cause problems:
devtools/client/inspector/markup/views/markup-container.js:600
await this.markup.walker.insertBefore(
We will need to instead use the walker that's contextual to the node being moved.
Additionally, something to think about: moving a node across an iframe probably does not work today already, but it's worth checking, and making sure we bail out nicely when the user tries to do it.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83a543bc7f15 Make drag/drop nodes work with Fission. r=pbro
Comment 3•5 years ago
|
||
bugherder |
Comment 4•5 years ago
|
||
Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
Description
•