Closed
Bug 1586798
Opened 5 years ago
Closed 5 years ago
Make renaming tagnames work with Fission
Categories
(DevTools :: Inspector, task, P1)
DevTools
Inspector
Tracking
(Fission Milestone:M4, firefox71 fixed)
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: pbro, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-reserve)
Attachments
(1 file)
In the markup-view, you can rename tagnames of nodes. This feature will need fixing for it to work with Fission iframes.
Indeed, at least this line of code will cause problems:
devtools/client/inspector/markup/views/element-editor.js:980 this.markup.walker.editTagName(this.node, newTagName).catch(() => {
We will need to instead use the walker that's contextual to the node being moved.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9099386 -
Attachment description: Bug 1586798 - Use WalkerFromt from the currently selected element in onTagEdit(). r=pbro → Bug 1586798 - Use WalkerFront from the currently selected element in onTagEdit(). r=pbro
|
||
Updated•5 years ago
|
Priority: P3 → P1
Whiteboard: dt-fission-reserve → dt-fission
|
|
||
Updated•5 years ago
|
Whiteboard: dt-fission → dt-fission-reserve
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/878ed0ad732f Use WalkerFront from the currently selected element in onTagEdit(). r=pbro
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
|
||
Comment 4•5 years ago
|
||
Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
Fission Milestone: --- → M4
You need to log in
before you can comment on or make changes to this bug.
Description
•