1586801 - Make duplicating a node work with Fission

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P1)

Description

[Patrick Brosset <:pbro>]

In the markup-view, you can duplicate nodes by using the contextual menu. This feature will need fixing for it to work with Fission iframes.

Indeed, at least this line of code will cause problems:

devtools/client/inspector/markup/markup-context-menu.js:193
this.walker.duplicateNode(this.selection.nodeFront).catch(console.error);

We will need to instead use the walker that's contextual to the node being moved.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1586801 - Use the contextual WalkerFront in _duplicateNode(). r=pbro

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e28d8852735
Use the contextual WalkerFront in _duplicateNode(). r=pbro

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4e28d8852735

Comment 4

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732