1586817 - Fix Flash plugins mochitest-browser tests that are broken with Fission enabled

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Those tests are:

browser/base/content/test/plugins/browser_CTP_context_menu.js
browser/base/content/test/plugins/browser_CTP_context_menu.js
browser/base/content/test/plugins/browser_bug744745.js
browser/base/content/test/plugins/browser_pluginCrashCommentAndURL.js
browser/base/content/test/plugins/browser_subframe_access_hidden_plugins.js

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Spoke to some DOM folk, and since we're EOL'ing Flash / NPAPI in 2020, we're not going to waste time updating these tests or getting NPAPI to work with oop iframes.

I'll submit a patch to add some commentary to that effect.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1586817 - Skip some browser/base/content NPAPI tests when Fission is enabled. r?kmag

The only reason I didn't disable the entire browser/base/content/test/plugins directory
was because there are a few tests in there that exercise GMP / EME stuff, and we
presumably still want those.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1194b1266180
Skip some browser/base/content NPAPI tests when Fission is enabled. r=kmag

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1194b1266180

Comment 5

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 6

[Chris Peterson [:cpeterson]]

We may need to support Flash in Fission after all. I'm reopening this Flash test bug, but postponing to Fission's Beta milestone (M7). We can reevaluate Fission's and Flash EOL's schedules.

Comment 7

[Neha Kochar [:neha]]

Flash is EOL