Closed Bug 1586819 Opened 2 years ago Closed 2 years ago

Add a command button to see which DevTools fission related preferences are currently enabled

Categories

(DevTools :: General, task)

task
Not set
normal

Tracking

(Fission Milestone:M4, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(2 files)

We start having a lot of preferences to drive all the experimental features around DevTools. We could have a small UI to list the preferences, say which one is enabled or not, and keep the description available.

Could this be exposed in preferences, or as section in the meatball dropdown?

(In reply to :Harald Kirschner :digitarald from comment #2)

Could this be exposed in preferences, or as section in the meatball dropdown?

I can see how this would make sense as we talk about extending this to more preferences.
But I think that defeats the initial purpose of this feature. And the summary of the bug is very short, so I should explain a bit more my motivations here :)

The fission-related experiments can be very experimental, and have sometimes no UI impact. (for instance the work related to target switching or js-window-actors). This UI is a way to make those preferences more visible. The fission/devtools preferences can also be closely linked sometimes (you need to test with pref A + C but not B to check a given scenario for instance).

It might be nice to have a global UI for all DevTools pref'd-off experiments.
A section in the settings could be fine for that (other than the fact that our settings are already super crowded).
In the end I think those are 2 separate requirements.

Attached image image.png

Thanks for the explainer, I think I understand the use case better (also from further comments in phab). To point out an existing UI where this might fit with the footgun icons, maybe this mockup explains it better. Would this solve the use case as well?

(In reply to :Harald Kirschner :digitarald from comment #4)

Created attachment 9099686 [details]
image.png

Thanks for the explainer, I think I understand the use case better (also from further comments in phab). To point out an existing UI where this might fit with the footgun icons, maybe this mockup explains it better. Would this solve the use case as well?

Ah thanks for the screenshot, yes it would work with this design.
That being said I don't think we should block this bug on the UI/UX decisions pending in https://github.com/firefox-devtools/ux/issues/60.
I would prefer to aim for a simple implementation here and when the footgun designs have landed, we can migrate if needed?

I would prefer to aim for a simple implementation here and when the footgun designs have landed, we can migrate if needed?

WFM, as this makes the Fission work easier.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6294022e7f66
Add DevTools command button to show the currently enabled devtools-fission prefs r=nchevobbe
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/971d8484db20
Backed out changeset 6294022e7f66 for devtools failure at devtools/client/framework/test/browser_toolbox_options_disable_buttons.js. On a CLOSED TREE
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2421742b70dd
Add DevTools command button to show the currently enabled devtools-fission prefs r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.