1586882 - Add parameters to the Lockwise link in Protection Report

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

The protection report in Fx70 Beta includes a link to lockwise.firefox.com. We should add some utm parameters to that link so that we can measure the impact of this channel in driving Lockwise engagement.

We could follow the pattern set by the Monitor link on the same report:

https://lockwise.firefox.com/?utm_source=about-protections

We should do this before Fx70 release launch.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1586882 - Add params to lockwise and proxy links from protection report.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cdb3133f50f
Add params to lockwise and proxy links from protection report. r=johannh

Comment 3

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Can you request uplift (today) once this gets to m-c?
It has to land today to make it into beta 14 build tomorrow morning.

Comment 4

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

ddurst is this also something you want to verify with marketing?

Comment 5

[David Durst [:ddurst]]

I'm going to assume that hoosteno is verifying this.

Comment 6

[David Durst [:ddurst]]

That said, if we should be doing something more robust here, like https://lockwise.firefox.com/ ?utm_source=firefox-desktop&utm_medium=referral&utm_campaign=about-protections&utm_content=about-protections (per hoosteno's spreadsheet), then we should. I can't tell who owns the final say of what links should be.

Comment 7

[Erica Wright [:ewright]]

Comment on attachment 9099639 [details]
Bug 1586882 - Add params to lockwise and proxy links from protection report.

Beta/Release Uplift Approval Request

• User impact if declined: We will not be able to measure impact of about:protections on the Lockwise product, and proxy (if we decide to enable it).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple pref change which adds params to a url
• String changes made/needed: none

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6cdb3133f50f

Comment 9

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

hoosteeno, do you want to weigh in on comment 6? Or is this fine as it is? Can you verify it's as it should be in nightly?

Comment 10

[Justin Crawford [:hoosteeno] [:jcrawford]]

Thanks, :lizzard.

My original request was intended to make this bug extremely expedient, because I thought it might be too late to be particular. But comment 6 is correct, and a better outcome here would include the following things:

a) standardized parameters that we try to use elsewhere, too
b) all 4 of the common utm parameters

So, with apologies for churn, I would prefer the URL on this link to be...

https://lockwise.firefox.com/
?utm_source=firefox-desktop&utm_medium=referral&utm_campaign=about-protections&utm_content=about-protections

Comment 11

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Erica if you can fix up the patch I am happy to take it for tomorrow's build!

Comment 12

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Asking the sheriffs to back out the first patch from m-c

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b109ea618eef
Backed out changeset 6cdb3133f50f by lizzard's request

Comment 14

[Erica Wright [:ewright]]

Thanks Liz, changed and up for review again.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc6e2d9f6b74
Add params to lockwise and proxy links from protection report. r=johannh

Comment 16

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5d7ecb0646db

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bc6e2d9f6b74

Comment 18

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191013213650), on Firefox Beta 70.0b14 (Build ID: 20191010142853), and on Firefox Release Candidate (Build ID: 20191014163058) on Windows 10 x64, Mac 10.14, and Ubuntu 16 x64.

• The “https://lockwise.firefox.com/?utm_source=firefox-desktop&utm_medium=referral&utm_campaign=about-protections&utm_content=about-protections” is displayed in the URL Bar after clicking the “Firefox Lockwise” link from the “about:protections” page. The link is only displayed if there are no saved logins on the used profile.