1586884 - The overflow menu arrow is overlaping the popup in customize mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Itiel]

Attachment: Screenshot

This is a regression from bug 1582530 (more spefically, the Fix remaining cases that were relying on blockification patch)

See attached.

Comment 1

[:Gijs (back August 25; he/him)]

[Tracking Requested - why for this release]:

(In reply to Itiel from comment #0)

more spefically, the Fix remaining cases that were relying on blockification patch

This doesn't really make sense to me; it doesn't look like that change touched the arrow in any way so I don't see how it'd affect this...

Anyway, :ntim/:dao/:dholbert, thoughts?

Comment 2

[Daniel Holbert [:dholbert]]

This was likely a regression from the other patch in that push, which flipped a pref to make it so some XUL elements that were implicitly getting forced to display:block will no longer have their display changed like that (so now they remain display:-moz-box).

Comment 3

[Daniel Holbert [:dholbert]]

If I flip layout.css.xul-box-display-values.survive-blockification.enabled = false and then enter customize mode, then I get EXPECTED RESULTS. (No need to restart Firefox even).

So this was definitely a regression from that pref-flip, and we likely just need to add an explicit display:block for some element here.

Comment 4

[Daniel Holbert [:dholbert]]

looks like the rule for...

#customization-panelWrapper > .panel-arrowbox {

...needs display:block, because that element's parent #customization-panelWrapper is display:flex, and flex containers blockify their children. (And until now, that has meant that it forced its child to display:block, but now it leaves it at display:-moz-box instead, which has a subtly different layout in this case, hence this bug report.)

Comment 5

[Daniel Holbert [:dholbert]]

Specifically this rule needs display:block:
https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/browser/themes/shared/customizableui/customizeMode.inc.css#460

Comment 6

[Tim Nguyen :ntim]

Attachment: Bug 1586884 - Fix overflow menu arrow appearance in customize mode. r=Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e80d0687f27
Fix overflow menu arrow appearance in customize mode. r=Gijs

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7e80d0687f27

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Reproduced the issue with Firefox 71.0a1 (20191007215350) on Windows 10x64.
The issue is verified fixed with Firefox 71.0b9 (20191111170815) on Windows 10x64, Ubuntu 18.04 and macOS 10.12.