Closed
Bug 1586887
Opened 6 years ago
Closed 6 years ago
Fix Window WebIDL methods which return BrowsingContext* instead of WindowProxyHolder
Categories
(Core :: DOM: Core & HTML, task, P2)
Core
DOM: Core & HTML
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
|
Bug 1586887: Return WindowProxyHolder rather than BrowsingContext from Window WebIDL getters. r=nika
47 bytes,
text/x-phabricator-request
|
Details | Review |
Several Window methods return BrowsingContext pointers for WebIDL getters which return WindowProxy. This works, but it also allows them to be misused by C++ callers.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Fission Milestone: --- → M4
Priority: -- → P2
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/aedc45de64b3
Return WindowProxyHolder rather than BrowsingContext from Window WebIDL getters. r=nika
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
||
Comment 4•6 years ago
|
||
Doesn't compile, you're missing some include:
/builds/worker/workspace/build/src/dom/base/nsGlobalWindowInner.h:590:35: error: incomplete result type 'mozilla::dom::WindowProxyHolder' in function definition
/builds/worker/workspace/build/src/dom/base/nsGlobalWindowInner.h:590:51: error: calling 'Window' with incomplete return type 'mozilla::dom::WindowProxyHolder'
https://hg.mozilla.org/mozilla-central/rev/aedc45de64b3e561e8f4ddd9311ac99af5367aff#l4.14
You need to log in
before you can comment on or make changes to this bug.
Description
•