1586888 - Test security/sandbox/test/browser_content_sandbox_fs.js has failures on macOS Catalina

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P2)

Description

[Haik Aftandilian [:haik]]

On macOS Catalina Betas, some tests in browser_content_sandbox_fs.js are failing because two directories used for tests/checks don't exist. Those are /Network and /Library/Widgets. We need to update the tests to take this into account.

$ ./mach test --headless security/sandbox/test/browser_content_sandbox_fs.js

Unexpected Results
------------------
security/sandbox/test/browser_content_sandbox_fs.js
  FAIL Uncaught exception - [Exception... "Component returned failure code: 0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST) [nsIFile.isDirectory]"  nsresult: "0x80520006 (NS_ERROR_FILE_TARGET_DOES_NOT_EXIST)"  location: "JS frame :: chrome://mochitests/content/browser/security/sandbox/test/browser_content_sandbox_utils.js :: GetDir :: line 96"  data: no]
Stack trace:
GetDir@chrome://mochitests/content/browser/security/sandbox/test/browser_content_sandbox_utils.js:96:17
testFileAccess@chrome://mochitests/content/browser/security/sandbox/test/browser_content_sandbox_fs.js:468:25
Tester_execTest/<@chrome://mochikit/content/browser-test.js:1350:34
async*Tester_execTest@chrome://mochikit/content/browser-test.js:1385:11
nextTest/<@chrome://mochikit/content/browser-test.js:1213:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
  FAIL Found an unexpected tab at the end of test run: about:blank -

Comment 1

[Haik Aftandilian [:haik]]

Attachment: Bug 1586888 - Test security/sandbox/test/browser_content_sandbox_fs.js has failures on macOS Catalina r?gcp

Don't test with directories not present on macOS 10.15.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2135df66bd7
Test security/sandbox/test/browser_content_sandbox_fs.js has failures on macOS Catalina r=gcp

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e2135df66bd7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c43044aedcd

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/331249719065

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2135df66bd7