1586950 - Web Authentication should use partial dictionaries now that it can

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P3)

Description

[Boris Zbarsky [:bzbarsky]]

WebAuthentication.webidl has various TODO comments about using partial dictionaries once they are supported. They have been supported for almost a year now...

I don't see an existing followup to bug 1406471 filed for this...

Comment 1

[J.C. Jones [:jcj] (he/they)]

Cool. When I work on WebAuthn again, will do. :)

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 1586950 - use partial dictionaries in WebAuthn webidl. r=#webidl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bad715e0f53e
use partial dictionaries in WebAuthn webidl. r=emilio

Comment 4

[Iulian Moraru]

Backed out 2 changesets (bug 1844437, bug 1586950) for causing wpt failures on remote-desktop-client-override.tentative.https.html.

• Push with failures

• Failure log

• Backout link

[task 2023-09-20T23:33:52.009Z] 23:33:52     INFO - TEST-START | /webauthn/remote-desktop-client-override.tentative.https.html
[task 2023-09-20T23:33:52.029Z] 23:33:52     INFO - Closing window 42c89faa-8e5b-4814-80da-87f1252bf506
[task 2023-09-20T23:33:52.518Z] 23:33:52     INFO - PID 1300 | [Parent 1300, Main Thread] WARNING: '!top', file /builds/worker/checkouts/gecko/dom/xul/MenuBarListener.cpp:99
[task 2023-09-20T23:33:52.740Z] 23:33:52     INFO - PID 1300 | [Parent 1300, Main Thread] WARNING: WaylandDisplayRelease(): Wayland display is missing!: file /builds/worker/checkouts/gecko/widget/gtk/nsWaylandDisplay.cpp:31
[task 2023-09-20T23:33:52.760Z] 23:33:52     INFO - Browser exited with return code 0
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - PROCESS LEAKS /tmp/tmphrx0zwaf/runtests_leaks_1181.log
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - leakcheck | Processing log file /tmp/tmphrx0zwaf/runtests_leaks_1181.log for scope /html/semantics/embedded-content
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 51200 bytes
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 10000 bytes
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - TEST-INFO | leakcheck | gmplugin process: leak threshold set at 20000 bytes
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 51200 bytes
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - TEST-INFO | leakcheck | vr process: leak threshold set at 0 bytes
[task 2023-09-20T23:33:52.763Z] 23:33:52     INFO - TEST-INFO | leakcheck | rdd process: leak threshold set at 51200 bytes
[task 2023-09-20T23:33:52.764Z] 23:33:52     INFO - TEST-INFO | leakcheck | socket process: leak threshold set at 0 bytes
[task 2023-09-20T23:33:52.765Z] 23:33:52     INFO - TEST-INFO | leakcheck | sandboxbroker process: leak threshold set at 0 bytes
[task 2023-09-20T23:33:52.766Z] 23:33:52     INFO - TEST-INFO | leakcheck | forkserver process: leak threshold set at 0 bytes
[task 2023-09-20T23:33:52.766Z] 23:33:52     INFO - TEST-INFO | leakcheck | utility process: leak threshold set at 0 bytes
[task 2023-09-20T23:33:52.767Z] 23:33:52     INFO - leakcheck | Processing leak log file /tmp/tmphrx0zwaf/runtests_leaks_1181_tab_pid3570.log
[task 2023-09-20T23:33:52.768Z] 23:33:52     INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2023-09-20T23:33:52.769Z] 23:33:52     INFO - leakcheck | Processing leak log file /tmp/tmphrx0zwaf/runtests_leaks_1181_tab_pid12003.log
[task 2023-09-20T23:33:52.770Z] 23:33:52     INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2023-09-20T23:33:52.770Z] 23:33:52     INFO - leakcheck | Processing leak log file /tmp/tmphrx0zwaf/runtests_leaks_1181_tab_pid8591.log
[task 2023-09-20T23:33:52.779Z] 23:33:52     INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2023-09-20T23:33:52.780Z] 23:33:52     INFO - leakcheck | Processing leak log file /tmp/tmphrx0zwaf/runtests_leaks_1181_tab_pid8022.log
[task 2023-09-20T23:33:52.780Z] 23:33:52     INFO - 
[task 2023-09-20T23:33:52.780Z] 23:33:52     INFO - TEST-UNEXPECTED-FAIL | /webauthn/remote-desktop-client-override.tentative.https.html | create() with remoteDesktopClientOverride - assert_unreached: Should have rejected: undefined Reached unreachable code
[task 2023-09-20T23:33:52.781Z] 23:33:52     INFO - .
[task 2023-09-20T23:33:52.781Z] 23:33:52     INFO - TEST-OK | /webauthn/remote-desktop-client-override.tentative.https.html | took 772ms
[task 2023-09-20T23:33:52.784Z] 23:33:52     INFO - TEST-PASS | leakcheck | tab no leaks detected!
[task 2023-09-20T23:33:52.784Z] 23:33:52     INFO - leakcheck | Processing leak log file /tmp/tmphrx0zwaf/runtests_leaks_1181_tab_pid1790.log
[task 2023-09-20T23:33:52.786Z] 23:33:52     INFO - PID 19772 | 1695252832784	Marionette	INFO	Stopped listening on port 33539
[task 2023-09-20T23:33:52.787Z] 23:33:52     INFO - TEST-PASS | leakcheck | tab no leaks detected!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98d65fd8ba44
use partial dictionaries in WebAuthn webidl. r=emilio

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/98d65fd8ba44