[BinAST] Optimize NaiveHuffmanTable for 2-entry table
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(3 files)
Currently NaiveHuffmanTable is used only for HuffmanTableIndexedSymbolsBool : NaiveHuffmanTable<bool, 2>
and HuffmanTableIndexedSymbolsMaybeInterface : NaiveHuffmanTable<BinASTKind, 2>
,
so we can optimize it by:
- remove template parameter
N
- remove
Vector
and add in-line array - possibly remove loop in
lookup
Assignee | ||
Comment 1•5 years ago
|
||
or maybe we can optimize it more by specializing for each case, so that we don't have to store value
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D49560
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D49561
Assignee | ||
Updated•5 years ago
|
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/aa843177070e Part 1: Making sure that we always call initWithSingleValue when we can. r=Yoric https://hg.mozilla.org/integration/autoland/rev/fbf2c90da04c Part 2: Add TwoEntriesHuffmanTable. r=Yoric https://hg.mozilla.org/integration/autoland/rev/7f0b3124697b Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r=Yoric
Comment 6•5 years ago
|
||
Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=272181996&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=272181899&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/31f16b9b58630abad5477ecf1c112af7218c324d
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/7516af0633d8 Part 1: Making sure that we always call initWithSingleValue when we can. r=Yoric https://hg.mozilla.org/integration/autoland/rev/5fb868fecf22 Part 2: Add TwoEntriesHuffmanTable. r=Yoric https://hg.mozilla.org/integration/autoland/rev/0d1c7409217a Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r=Yoric
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7516af0633d8
https://hg.mozilla.org/mozilla-central/rev/5fb868fecf22
https://hg.mozilla.org/mozilla-central/rev/0d1c7409217a
Assignee | ||
Updated•5 years ago
|
Description
•