Closed Bug 1586975 Opened 4 months ago Closed 3 months ago

[BinAST] Optimize NaiveHuffmanTable for 2-entry table

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

Currently NaiveHuffmanTable is used only for HuffmanTableIndexedSymbolsBool : NaiveHuffmanTable<bool, 2> and HuffmanTableIndexedSymbolsMaybeInterface : NaiveHuffmanTable<BinASTKind, 2>,
so we can optimize it by:

  • remove template parameter N
  • remove Vector and add in-line array
  • possibly remove loop in lookup
Blocks: 1577764

or maybe we can optimize it more by specializing for each case, so that we don't have to store value

Priority: -- → P3
Depends on: 1587663

Depends on D49560

Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/aa843177070e
Part 1: Making sure that we always call initWithSingleValue when we can. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/fbf2c90da04c
Part 2: Add TwoEntriesHuffmanTable. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/7f0b3124697b
Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r=Yoric
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/7516af0633d8
Part 1: Making sure that we always call initWithSingleValue when we can. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/5fb868fecf22
Part 2: Add TwoEntriesHuffmanTable. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/0d1c7409217a
Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r=Yoric
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Flags: needinfo?(arai.unmht)
Blocks: 1591444
You need to log in before you can comment on or make changes to this bug.