1586975 - [BinAST] Optimize NaiveHuffmanTable for 2-entry table

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Currently NaiveHuffmanTable is used only for HuffmanTableIndexedSymbolsBool : NaiveHuffmanTable<bool, 2> and HuffmanTableIndexedSymbolsMaybeInterface : NaiveHuffmanTable<BinASTKind, 2>,
so we can optimize it by:

• remove template parameter N
• remove Vector and add in-line array
• possibly remove loop in lookup

Comment 1

[Tooru Fujisawa [:arai]]

or maybe we can optimize it more by specializing for each case, so that we don't have to store value

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1586975 - Part 1: Making sure that we always call initWithSingleValue when we can. r?Yoric

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1586975 - Part 2: Add TwoEntriesHuffmanTable. r?Yoric

Depends on D49560

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1586975 - Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r?Yoric

Depends on D49561

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa843177070e
Part 1: Making sure that we always call initWithSingleValue when we can. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/fbf2c90da04c
Part 2: Add TwoEntriesHuffmanTable. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/7f0b3124697b
Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r=Yoric

Comment 6

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=00eab227096178b7d95e0a375cb25a300095219b&selectedJob=272181996

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=272181996&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=272181899&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/31f16b9b58630abad5477ecf1c112af7218c324d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7516af0633d8
Part 1: Making sure that we always call initWithSingleValue when we can. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/5fb868fecf22
Part 2: Add TwoEntriesHuffmanTable. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/0d1c7409217a
Part 3: Remove NaiveHuffmanTable and use GenericHuffmanTable instead. r=Yoric

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7516af0633d8
https://hg.mozilla.org/mozilla-central/rev/5fb868fecf22
https://hg.mozilla.org/mozilla-central/rev/0d1c7409217a