1587045 - Remove dom.webnotifications.allowinsecure preference

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, task, P2)

Description

[Anne (:annevk)]

We don't have this for other features we restrict to secure contexts. If we want this kind of functionality we should fix bug 1409841 and not have case-by-case workarounds.

And also, we shouldn't really have preferences long term that we don't expect to ever flip and would make things less secure for users if they flip them.

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1587045 - Remove dom.webnotifications.allowinsecure pref r?#dom-core!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b12f2488fd46
Remove dom.webnotifications.allowinsecure pref r=dom-core,edgar

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in dom/notification/test/mochitest/test_notification_insecure_context.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/bc69b210f50256a5dfd8ea1030f9bc88501877ba

Push with failures

Failure log -> TEST-UNEXPECTED-PASS | dom/notification/test/mochitest/test_notification_insecure_context.html | fail-if condition in manifest - We expected at least one failure

Comment 4

[Gregory Pappas [:gregp]]

Thanks, working on it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a53e4599fe
Remove dom.webnotifications.allowinsecure pref r=dom-core,edgar

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/88a53e4599fe