1587062 - [Fission] Make sandbox attribute works for out-of-process iframes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Edgar Chen [:edgar]]

Checking bug 1586772 I found that the sandbox attribute doesn't be synced to out-of-process iframe when fission enables.

Comment 1

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a2f16176acea4d9d76e6efdf715755effd39eff

Comment 2

[Edgar Chen [:edgar]]

It looks like that sandboxFlags should move from Docshell to BrowsingContext. There is one consumer for nsIDocShell.sandboxFlags, https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/toolkit/components/thumbnails/content/backgroundPageThumbsContent.js#52, it looks like we need to provide an alternative way to access sandboxFlags.

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87f77cca5b53e61e9d895b6503c88e4a62e7f05e

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1587062 - Move SandboxFlags from DocShell to BrowsingContext;

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fc7e9873a39
Move SandboxFlags from DocShell to BrowsingContext; r=smaug

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4fc7e9873a39

Comment 7

[Toshihito Kikuchi [:toshi]]

I hit a compile error when building Thunderbird saying GetSandboxFlags is not defined at this line. It seems that the method was moved by the patch above. Edgar, could you look into this compile error?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6797b9e2d931
Port bug 1587062 - Move SandboxFlags from DocShell to BrowsingContext. rs=bustage-fix

Comment 9

[Toshihito Kikuchi [:toshi]]

Jorg's patch worked. Thanks!

Comment 10

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732