1587086 - "Copy" (ctrl/cmd+c) on a selected url copies the url into the clipboard

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[kud]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

[Feature Request]

"Copy" (ctrl/cmd+c) on a selected url copies the url into the clipboard

Comment 1

[:Harald Kirschner :digitarald]

Honza, would this be a good first bug?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some instruction for anyone interested in this bug:

1. Here is a place where we handle key-shortcut for opening the Search panel
   https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/devtools/client/netmonitor/src/components/Toolbar.js#178

2. we can introduce a new similar handler for copying the URl

this.shortcuts.on(COPY_URL_KEY_SHORTCUT, event => {
  event.preventDefault();
  
 // get selected request and copy its URL into the clipboard
});

3. Here is a place showing how to get the selected request
   https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/devtools/client/netmonitor/src/components/MonitorPanel.js#246

Similar thing should be done in the Toolbar component (mentioned in #1)

Honza

Comment 3

[shivamrawat6670]

I would like to work on this issue.

Comment 4

[Ksenia Berezina [:ksenia]]

If :shivamrawat6670 is not working on this, is it ok to take it?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Ksenia Berezina [:ksenia] from comment #4)

If :shivamrawat6670 is not working on this, is it ok to take it?

Absolutely, thanks for the help!

Honza

Comment 6

[Ksenia Berezina [:ksenia]]

Attachment: Bug 1587086 - Add a listener to be able to "Copy" (ctrl/cmd+c) a selected url to the clipboard

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e32694af97f
Add a listener to be able to "Copy" (ctrl/cmd+c) a selected url to the clipboard r=Honza

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2e32694af97f