1587190 - Crash in [@ webrender::picture::TileNode::update_dirty_rects]

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-d7ba3e48-bca4-4342-a84e-032d60191006.

Seen while looking at nightly crash stats: https://bit.ly/2OG1Mrh. Crashes started in 20191005100501 and are Windows only. 4 crashes/2 installs so far.

Looks as if it may be related to Bug 1580063.

Top 7 frames of crashing thread:

0 xul.dll static void webrender::picture::TileNode::update_dirty_rects gfx/wr/webrender/src/picture.rs:4491
1 xul.dll static void webrender::picture::TileNode::update_dirty_rects gfx/wr/webrender/src/picture.rs:4493
2 xul.dll static void webrender::picture::TileNode::update_dirty_rects gfx/wr/webrender/src/picture.rs:4493
3 xul.dll static void webrender::picture::TileCacheInstance::post_update gfx/wr/webrender/src/picture.rs:1839
4 xul.dll static union core::option::Option<euclid::rect::Rect<f32, webrender_api::units::PicturePixel>> webrender::prim_store::PrimitiveStore::update_visibility gfx/wr/webrender/src/prim_store/mod.rs:2317
5 xul.dll static union core::option::Option<euclid::rect::Rect<f32, webrender_api::units::PicturePixel>> webrender::prim_store::PrimitiveStore::update_visibility gfx/wr/webrender/src/prim_store/mod.rs:1978
6 xul.dll static union core::option::Option<webrender::render_task_graph::RenderTaskId> webrender::frame_builder::FrameBuilder::build_layer_screen_rects_and_cull_layers gfx/wr/webrender/src/frame_builder.rs:341

Comment 1

[Kris Taeleman (:ktaeleman)]

Hey Glenn, could you take a look at this?

Comment 2

[Glenn Watson [:gw]]

Unfortunately the call stack doesn't show anything obvious, and the crash volume is very low (just a couple of crashes so far, it seems). We'll probably need a URL + repro steps in order to resolve this one.

Comment 3

[Marcia Knous [:marcia]]

URLs are:

• https://www.overclock.net/forum/index.php
• https://www.youtube.com/watch?v=mwi1iTWU4RY

Comment 4

[Glenn Watson [:gw]]

Thanks! I have done a bit of testing with those URLs and been unable to repro so far. Is anyone else able to reliably reproduce the crash?

Comment 5

[Marcia Knous [:marcia]]

Adding Timea to see if someone at Softvision can try to reproduce. All 4 crashes were from Win 10.0.18362.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Hey Marcia, tried to reproduce on my system but I have Intel graphics and can't reproduce the issue.
All of the crashes where on AMD systems, so I will redirect this to a colleague with AMD card to take a look over it.

Comment 7

[Peter Magyari (Desktop QA)]

The crash doesn't occur on my end either.
I've got an AMD RX550 and I'm using Window 10.0.18362

Comment 8

[Julien Cristau [:jcristau]]

P3, low volume and we haven't been able to reproduce, I'll call this fix-optional for 71 for now.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

I'll call this FIXED

Comment 10

[Paul Zühlcke [:pbz]]

Just had a crash with this signature https://crash-stats.mozilla.org/report/index/299b254f-6f97-4d06-965b-6d02d0220505. I don't have specific STR though. I was chatting on Slack while it happened.