Closed
Bug 1587206
Opened 5 years ago
Closed 5 years ago
[flake8] Enable more flake8 rules
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox71 fixed)
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(4 files)
We skip a few flake8 rules here:
https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/.flake8#100
We should enable these (or decide they're unwanted).
|
Assignee | |
Comment 1•5 years ago
|
||
This ensures we use ==/!= to strings and ints (instead of is/is not).
|
|
Assignee | |
Comment 2•5 years ago
|
||
This prevents '>>' with print statements. Since this syntax is still valid in
Python 2, I exluded dirs that contain this error rather than fix them.
Depends on D48609
|
|
Assignee | |
Comment 3•5 years ago
|
||
This prevents redefinition of unused variables.
Depends on D48610
|
|
Assignee | |
Comment 4•5 years ago
|
||
Prevents over-indentation.
Depends on D48611
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2921dbcceadc [lint.flake8] Enable F632 across the tree, r=sylvestre https://hg.mozilla.org/integration/autoland/rev/1d6d7e7ddbbd [lint.flake8] Enable F633 across the tree, r=sylvestre https://hg.mozilla.org/integration/autoland/rev/b4d2e6a7f790 [lint.flake8] Enable F811 across the tree, r=sylvestre https://hg.mozilla.org/integration/autoland/rev/f3f4aa35d46e [lint.flake8] Enable E117 across the tree, r=sylvestre
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → ahal
Status: NEW → ASSIGNED
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2921dbcceadc
https://hg.mozilla.org/mozilla-central/rev/1d6d7e7ddbbd
https://hg.mozilla.org/mozilla-central/rev/b4d2e6a7f790
https://hg.mozilla.org/mozilla-central/rev/f3f4aa35d46e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•