1587208 - downloads not working when add-ons intercept them (and can't distinguish them)

Status: RESOLVED DUPLICATE of bug 1445211

(WebExtensions :: Request Handling, defect)

Description

[Matthew Woehlke]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Right-click on an image and select "save image as..."

Actual results:

The image is not saved; Download manager reports that the download failed.

Expected results:

After selecting a save location, the image is written to disk.

Comment 1

[Matthew Woehlke]

(What happened to "Additional Information"? What happened to being able to edit the description?)

Additional Information:

This has been 100% reproducible with the main comic images from www.gocomics.com for some time. Recently it has started affecting other sites, and the most recent update appears to have made the problem much more prevalent.

Simply retrying the download (clicking the 'retry' icon in Download Manager) causes the download to succeed.

I suspect there is something actually broken here, but at least FF should automatically retry the download a couple times, which should significantly mitigate the issue.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Marco Bonardo [:mak]]

Please try upgrading to Firefox 69.0.3 and let us know if that helped.

If it's still happening, please attach a log from about:support page.

Comment 4

[Matthew Woehlke]

Attachment: Output of about:support

Comment 5

[Matthew Woehlke]

This is NOT resolved, and it still happens in 70.0. Please re-open.

Comment 6

[Matthew Woehlke]

(Never mind; found the edit button. Version has been updated accordingly.)

BTW, this is reproducible on at least two different computers with slightly different configurations. I can probably get an about:support dump from the other one, if it's useful? However, I can't update FF because no newer version has been packaged for Fedora 29, and Fedora 30 doesn't work with the GPU in that machine.

Comment 7

[Marco Bonardo [:mak]]

You have a lot of extensions that manage traffic: AdBlock Plus, NoScript, HPTTS Everywhere, uMatrix. It's hard to tell if some of them may be involved. Could you please try reproducing in Safe mode (https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode) and on a clean profile (https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles) so that we can exclude the effect of such add-ons from troubleshooting?

Comment 8

[Matthew Woehlke]

I tried to reproduce on a live image. It's reproducible with stock FF + uMatrix.

Comment 9

[Matthew Woehlke]

...and, looking over https://github.com/uBlockOrigin/uMatrix-issues/issues/92, it seems like there may be room for improvement on FF's side. In particular, uMatrix seems to be having problems distinguishing user-initiated downloads from the general catch-all bucket of "other" requests. ISTM that it would be significantly helpful if FF could report these in a distinctive manner.

(Possibly related? https://bugzilla.mozilla.org/show_bug.cgi?id=1343466)

Comment 10

[Marco Bonardo [:mak]]

So it looks like this is more about WebExtensions not marking requests properly (or not in a detailed way), that may also require downloads backend work, but should start from a WebExt requirements analysis.

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Let's keep this in one bug.