1587227 - First click on "send tab to device" does nothing if sync hasn't yet loaded.

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Immediately after starting the browser, clicking "send tab to device" doesn't show anything. Subsequent clicks do. This it true both when sync is and is not configured - on both cases, it seems Weave.service.clientsEngine is null.

I suspect this was regressed by bug 1583413.

(while digging in to this, I noticed the lastModified for fxa clients is always null, but the device records now includes this info, so I made that change too.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1587227 - ensure sendtab devices list is populated before Sync is initialized. r?lina

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c30194bd49f9
ensure sendtab devices list is populated before Sync is initialized. r=lina

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset c30194bd49f9 (Bug 1587227) for failing in browser_contextmenu_sendpage.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=270383834&resultStatus=testfailed%2Cbusted%2Cexception&revision=c30194bd49f9421f9b7339470960fc12fede17de

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270383834&repo=autoland&lineNumber=12767
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270383520&repo=autoland&lineNumber=2739

Backout: https://hg.mozilla.org/integration/autoland/rev/26ebfec0883457409f3d2ff8bc882b3b6f4936b2

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8900dfdffb26b0fc3e1c59085029b364776446fe

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4811c7e4836a
ensure sendtab devices list is populated before Sync is initialized. r=lina

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4811c7e4836a

Comment 7

[Miruna Curtean]

Verified fixed on Windows pro 10 64-bit and Ubuntu 18.04.3 LTS with Firefox Beta 71.0b7 (20191104135555) and Nightly 72.0a1 (20191105095755).
Tests were performed:

1. with the no account sign in. Browser was launched with a restored wikipedia page and the "Send tab to device" from both FxA panel and Hamburger menu account take the user to the "Send tab to device" where the "Sign in to Firefox" button is available.
2. with the account signed on only one device/ browser. Browser was launched with a restored wikipedia page and the "Send tab to device" from both FxA panel and Hamburger menu account take the user to the "Send tab to device" where the "Connect to another device" button is available.
3. with the account signed in multiple devices/ browsers. Browser was launched with a restored wikipedia page and the "Send tab to device" from both FxA panel and Hamburger menu account take the user to the "Send tab to device" a list of all devices is available even before Sync is performed.