1587232 - ./mach vendor rust leaves the tree in an unclear state if it would bring in a file that's too large

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Dana Keeler (she/her) [:keeler]]

STR: add pkcs11 = "0.3.1" to security/manager/ssl/cert_storage/Cargo.toml, commit, and then run ./mach vendor rust. This fails for me with the message:

    Updating crates.io index
    Updating git repository `https://github.com/alexcrichton/mio-named-pipes`
    Updating git repository `https://github.com/NikVolf/tokio-named-pipes`
      Adding libloading v0.4.3
      Adding num-bigint v0.1.44
      Adding pkcs11 v0.3.1
      Adding rand v0.4.6
      Adding rustc-serialize v0.3.24
 0:10.40 The following files exceed the filesize limit of 102400:

third_party/rust/rustc-serialize/src/json.rs

Please find a way to reduce the sizes of these files or talk to a build
peer about the particular large files you are adding.

The changes from `mach vendor rust` will NOT be added to version control.

At that point, my tree has a ton of removed but uncommitted files and it's unclear what I'm supposed to do (hg revert . && rm -f $(hg st -un), basically). As a developer, this is confusing and unfriendly.

Comment 1

[Ricky Stewart]

Attachment: Bug 1587232 - ./mach vendor rust leaves the tree in an unclear state if it would bring in a file that's too large

...or. Unfortunately, cargo vendor also updates the repo's root Cargo.lock file in-place and while we could git checkout/hg revert that file for the user, Cargo.lock may have had pre-existing changes that would be overwritten by such a change. Instead of a potentially destructive update in the error case, I've opted to add an extra error message to tell you how to deal with that one file.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/148f63236593
/mach vendor rust leaves the tree in an unclear state if it would bring in a file that's too large r=firefox-build-system-reviewers,mshal

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/148f63236593