1587366 - WebVR enumeration promises are not resolved when a session is restored

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Imanol Fernandez]

STR using Firefox Reality and Oculus Quest/Go:

• Open WebVR sample
• The EnterVR button is visible
• Click on the home button
• Quit FxR and reopen it again
• The session is restored and the EnterVR button is not visible

Comment 1

[Imanol Fernandez]

After some research I found this happens because vmp->GetVRActiveStatus() always returns false in VRManager.cpp after a session is restored. This causes the navigatio.getVRDisplays() promises to never be resolved.

VRActiveStatus is set true/false in nsGlobalWindowOuter::SetIsBackground but there is a race condition where the SetIsBackground method can be called before VREventObserver is created, so background active status changes are not sent correctly in that case.

I also found that VRManager::Shutdown() method is called after the FxR app goes to foreground due to the inactivity timer.

Comment 2

[Imanol Fernandez]

Attachment: Bug 1587366 - Fix VRManagerParent::GetVRActiveStatus race condition: Notify VRActiveStatus after a the VREventObserver is created.

Notify VRActiveStatus after a the VREventObserver is created to prevent the VRManagerParent::GetVRActiveStatus race condition.
Call VRManager::Shutdown() when the app goes to background instead of calling it in the foreground event due to the inactivity timer.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7f931c95c78
Fix VRManagerParent::GetVRActiveStatus race condition: Notify VRActiveStatus after a the VREventObserver is created. r=rbarker,daoshengmu

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c7f931c95c78

Comment 5

[Imanol Fernandez]

I found a regression due to calling VRManager::Shutdown() when the app goes to background. I'll remove that call for now, the restore problem is fixed with the VREventObserver fix.

Comment 6

[Imanol Fernandez]

Attachment: Bug 1587366 - Do not call VRManager::Shutdown immediately when the app is paused.

Do not call VRManager::Shutdown immediately when the app is paused.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/210a032a7f17
Do not call VRManager::Shutdown immediately when the app is paused. r=daoshengmu,kip

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/210a032a7f17