Open Bug 1587409 Opened 1 year ago Updated 4 months ago

Audit usage of nsIDocShellTreeItem in nsContentUtils::FirePageShowEventForFrameLoaderSwap and nsContentUtils::FirePageHideEventForFrameLoaderSwap

Categories

(Core :: DOM: Navigation, task, P2)

task

Tracking

()

Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:hard])

https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/dom/base/nsContentUtils.cpp#7797

This code calls OnPageHide() and OnPageShow() respectively, on all children which are descendents of the current docshell tree item.

This is called from frame-swapping code only (when loaders are being swapped) it seems. This method should be left alone, but the frame-loading code needs to be changed to call this method on each fragment individually.

Subsequently, this method should be renamed to document the fact that it only performs on the in-process fragment of the docshell tree.

Whiteboard: [rm-docshell-tree-item:hard]
Fission Milestone: --- → M5
Priority: -- → P2
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Summary: Fix usage of nsIDocShellTreeItem in nsContentUtils::FirePageShowEventForFrameLoaderSwap and nsContentUtils::FirePageHideEventForFrameLoaderSwap → Audit usage of nsIDocShellTreeItem in nsContentUtils::FirePageShowEventForFrameLoaderSwap and nsContentUtils::FirePageHideEventForFrameLoaderSwap

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Fission Milestone: M6 → M6b
Type: defect → task
Fission Milestone: M6b → Future
You need to log in before you can comment on or make changes to this bug.