Open Bug 1587418 Opened 3 months ago Updated 2 months ago

Fix usage of nsIDocShellTreeItem in nsContentUtils::ShouldBlockReservedKeys

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

Fission Milestone M6

People

(Reporter: djvj, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [rm-docshell-tree-item:sync-state])

https://searchfox.org/mozilla-central/rev/7cc0f0e89cb40e43bf5c96906f13d44705401042/dom/base/nsContentUtils.cpp#9597

(Move state to BrowsingContext).

This code retrieves the same-type root from the docshell tree, and then checks the following property of the principal for the root document:

IsSitePermDeny(rootPrincipal, "shortcuts").

The callers of this is key-handling code. Does not seem like this method would be called in contexts where only in-process tree fragments are accessed, and that this query may cross process boundaries.

This check is likely done frequently, and not a candidate for IPC or active querying. The result of this query can be cached ahead of time in the BrowsingContext tree and used from there.

Whiteboard: [rm-docshell-tree-item:sync-state]
Fission Milestone: --- → M5
Priority: -- → P2
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
You need to log in before you can comment on or make changes to this bug.