1587419 - Network Panel Search - Search keyword does not appear in the input text box field after reopening network panel search

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Marcela (Please NI request to Brindusa Tot)]

Attachment: Reopen Search_Test missing.mp4

After doing a search and closed using the X, when you open again the Network Panel Search, search keyword does not appear

Affected versions
Firefox versions Nightly 71.0a1

Affected platforms
Windows 10

Steps to reproduce

• Launch the Firefox Browser, open Dev Tools and select Network feature from the Devtool tab
• Open Network Panel Search
• Write some word in the search input box, press Enter key and close search panel Clicking (X) button at the top right side of the Search panel
• Open Network Panel Search again

Expected Result
The keyword in the input text box should be there if the panel is closed and re-opened

Actual Result
Search keyword does not appear in the input text box field

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report, I can reproduce this on my machine!

Honza

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Lloan, perhaps this is simple to fix?

Honza

Comment 3

[lloan alas:[lloanalas]]

@honza

Will take a look, should be an easy fix. Can we go ahead and assign this one to me, :)?

Thanks!

Comment 4

[lloan alas:[lloanalas]]

Attachment: Bug 1587419 - Search keyword does not appear in the input text box field after reopening network panel search. r=honza

Comment 5

[lloan alas:[lloanalas]]

@honza

I just pushed a patch for you to review.

based on this update, will we need the 'clear results' button back within the search input (we removed it in a previous request).

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to lloan alas:[lloanalas] from comment #5)

@honza

I just pushed a patch for you to review.

Thanks! Just post my comments.

based on this update, will we need the 'clear results' button back within the search input (we removed it in a previous request).

I am not sure if I understand what you mean. The search input has clear button if there is a text in it, no?

Honza

Comment 7

[lloan alas:[lloanalas]]

@honza

Updated the patch and disregard the question, brain-fart here - you're right, the input does have a clear button. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42d6a0fb0b62
Search keyword does not appear in the input text box field after reopening network panel search. r=Honza

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/42d6a0fb0b62

Comment 10

[Marcela (Please NI request to Brindusa Tot)]

Verified-fixed on Nightly 71.0a1, latest Nightly 72.0a1, Beta 71.0b5 using Windows 10 x64, macOS 10.14-macOS 10.15 and Ubuntu 18.04
Closing it as verified - fixed.