1587447 - Perma dom/serviceworkers/test/browser_devtools_serviceworker_interception.js | Test timed out - when Gecko 71 merges to Beta on 2019-10-14

Status: VERIFIED FIXED

(Core :: DOM: Service Workers, defect, P2)

Description

[Narcis Beleuzu [:NarcisB]]

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=cb7f32501a17e2dd1003d1ae2b1944658ac613c7&selectedJob=270467210

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270467326&repo=try&lineNumber=14612

Log snippet:

[task 2019-10-09T12:45:14.177Z] 12:45:14 INFO - TEST-PASS | dom/serviceworkers/test/browser_devtools_serviceworker_interception.js | Service worker intercepted the channel as expected - true == true -
[task 2019-10-09T12:45:14.177Z] 12:45:14 INFO - Console message: [JavaScript Error: "ReferenceError: isParentInterceptEnabled is not defined" {file: "resource://testing-common/content-task.js line 62 > eval" line: 61}]
[task 2019-10-09T12:45:14.178Z] 12:45:14 INFO - Buffered messages finished
[task 2019-10-09T12:45:14.179Z] 12:45:14 INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/browser_devtools_serviceworker_interception.js | Test timed out -
[task 2019-10-09T12:45:14.179Z] 12:45:14 INFO - GECKO(4811) | MEMORY STAT | vsize 2941MB | residentFast 322MB | heapAllocated 103MB
[task 2019-10-09T12:45:14.182Z] 12:45:14 INFO - TEST-OK | dom/serviceworkers/test/browser_devtools_serviceworker_interception.js | took 90028ms
[task 2019-10-09T12:45:14.183Z] 12:45:14 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-09T12:45:14.184Z] 12:45:14 INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/browser_devtools_serviceworker_interception.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/dom/serviceworkers/test/empty.html -
[task 2019-10-09T12:45:14.184Z] 12:45:14 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-09T12:45:14.193Z] 12:45:14 INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/browser_devtools_serviceworker_interception.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/dom/serviceworkers/test/empty.html -
[task 2019-10-09T12:45:14.194Z] 12:45:14 INFO - GECKO(4811) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmptfXBIJ.mozrunner/runtests_leaks_tab_pid5078.log
[task 2019-10-09T12:45:14.194Z] 12:45:14 INFO - checking window state

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

It looks like the problem here is that:

• the checkObserver function consults "isParentIntercept" enabled at https://searchfox.org/mozilla-central/rev/c8933daeb71df02566407eff88904ee981a7bcdd/dom/serviceworkers/test/browser_devtools_serviceworker_interception.js#76
• Under parent intercept, the function is run directly at https://searchfox.org/mozilla-central/rev/c8933daeb71df02566407eff88904ee981a7bcdd/dom/serviceworkers/test/browser_devtools_serviceworker_interception.js#172
• But when not under parent-intercept, the task is run via ContentTask.spawn at https://searchfox.org/mozilla-central/rev/c8933daeb71df02566407eff88904ee981a7bcdd/dom/serviceworkers/test/browser_devtools_serviceworker_interception.js#174 and the eval context the stringified function is evaluated in lacks the value in the lexical scope.

While we intend for the parent-intercept mode to ride the trains, we should fix the test.

Comment 2

[Intermittent Failures Robot]

1 failures in 3801 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1587447&startday=2019-10-07&endday=2019-10-13&tree=all

Comment 3

[Intermittent Failures Robot]

28 failures in 536 pushes (0.052 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 28

Platform breakdown:

• linux64: 4
• macosx1014-64: 2
• windows10-64: 3
• windows10-64-qr: 2
• macosx1014-64-shippable: 2
• macosx1014-64-devedition: 2
• windows7-32: 2
• linux64-devedition: 2
• linux64-shippable: 1
• windows7-32-devedition: 2
• windows10-64-devedition: 2
• windows7-32-shippable: 2
• windows10-64-shippable-qr: 1
• windows10-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1587447&startday=2019-10-14&endday=2019-10-14&tree=all

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Bug 1587447 - Make isParentInterceptEnabled an arg for spawned child-intercept version. r=perry

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/122a3f51fd9b
Make isParentInterceptEnabled an arg for spawned child-intercept version. r=perry

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/122a3f51fd9b

Comment 7

[Arthur Iakab [arthur_iakab]]

Verified in today's beta sim Early beta https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=411419d4250c8a975474b4434e4f0a2488866218&searchStr=browser%2Cchrome

Late beta https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=272039040&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=838f756dc13b0c93f831dd9886fadefe9e229133&searchStr=bc

Comment 8

[Intermittent Failures Robot]

35 failures in 3964 pushes (0.009 failures/push) were associated with this bug in the last 7 days.

This is the #43 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 35

Platform breakdown:

• linux64: 4
• macosx1014-64: 3
• windows10-64: 5
• windows10-64-qr: 4
• macosx1014-64-shippable: 2
• macosx1014-64-devedition: 2
• windows7-32: 2
• linux64-devedition: 3
• linux64-shippable: 2
• windows7-32-devedition: 2
• windows10-64-devedition: 2
• windows10-64-shippable-qr: 1
• windows10-64-shippable: 1
• windows7-32-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1587447&startday=2019-10-14&endday=2019-10-20&tree=all