1587468 - Update syn and quote to 1.0

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Emilio Cobos Álvarez [:emilio]]

https://hg.mozilla.org/integration/autoland/rev/713dee70307d pulls the new syn and quote versions. We should update all the crates to not duplicate the dependency.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

PRs to track:

• https://github.com/rust-lang-nursery/failure/pull/329 (for some reason we have a dependency from failure from a few crates that are hard to get rid of).
• https://github.com/JelteF/derive_more/ needs a release, but it's updated on trunk.
• https://github.com/bholley/malloc_size_of_derive/pull/3
• https://github.com/m4b/scroll/pull/61 (this is used by the profiler)

And then there's the workspace-hack which uses syn and quote with very concrete dependencies. I'll try to figure out what the right thing to do is there.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update cssparser to v0.25.9.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update cssparser-macros to 0.3.6.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update cstr-macros to v0.1.6.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update headers_derive to v0.1.1.

This is only used by webdriver.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update num_derive to 0.3.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update syn / quote / synstructure in peek-poke-derive.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a1a65319a43
Update cssparser to v0.25.9. r=boris
https://hg.mozilla.org/integration/autoland/rev/6e641b4a78b5
Update cssparser-macros to 0.3.6. r=boris
https://hg.mozilla.org/integration/autoland/rev/d773bdf9f8e0
Update cstr-macros to v0.1.6. r=boris

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/241a2e6159b0
Update num_derive to 0.3. r=boris
https://hg.mozilla.org/integration/autoland/rev/16c3040fb388
Update syn / quote / synstructure in peek-poke-derive. r=jrmuizel

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405b9a7fec75
Add syn/quote/etc to the list of allowed duplicated WR dependencies for now. r=bustage

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4a1a65319a43
https://hg.mozilla.org/mozilla-central/rev/6e641b4a78b5
https://hg.mozilla.org/mozilla-central/rev/d773bdf9f8e0
https://hg.mozilla.org/mozilla-central/rev/241a2e6159b0
https://hg.mozilla.org/mozilla-central/rev/16c3040fb388
https://hg.mozilla.org/mozilla-central/rev/405b9a7fec75

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/091a5a4ec150
Update headers_derive to v0.1.1. r=ato

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/091a5a4ec150

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update failure_derive and malloc_size_of_derive. r=heycam

This removes an old version of synstructure.

Comment 15

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update serde and related crates. r=nical

We are no longer using a pinned version of serde, so update to avoid the
dependency on older syn / quote / etc.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b168e040a286
Update failure_derive and malloc_size_of_derive. r=heycam

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b168e040a286

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/285df50f96b2
Update serde and related crates. r=nical

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/285df50f96b2

Comment 20

[Mike Hommey [:glandium]]

Attachment: Bug 1587468 - Update object to 0.16.0 and goblin to 0.1.2.

This has the side effect of adding another version of uuid, which we'll
upgrade for other dependencies subsequently.

Comment 21

[Mike Hommey [:glandium]]

Attachment: Bug 1587468 - Update uuid to 0.8.1.

This leaves one out-of-tree of uuid 0.7, handled by https://github.com/mozilla/rkv/pull/184
(but we have two copies of that, we'd need to have it landed on both
branches and pulled).

Comment 22

[Mike Hommey [:glandium]]

With the two patches I attached, we're down to 3 dependencies on syn < 1.0:

• one from derive_more, which emilio addressed in part with https://github.com/mozilla/neqo/commit/06df157225f4bbac5adbba98f0c6ba2644847d64 , and when that lands in-tree, we can update the other in-tree crates that use derive_more.
• one from num-derive, which I addressed in https://github.com/PLSysSec/lucet_sandbox_compiler/pull/4
• one from packed_struct_codegen, which was added in bug 1597989, and bbouvier said he wanted to remove that dependency.

I'm tempted to add a check in mach vendor rust that errors out if we add another version of syn...

Comment 23

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update derive_more. r=#build

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69e99d87df48
Update derive_more. r=glandium

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebb4441eb500
follow-up: Update webrender's lockfile in a CLOSED TREE.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eef1d8be4e7b
Update object to 0.16.0 and goblin to 0.1.2. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c0280f40a197
Update uuid to 0.8.1. r=webdriver-reviewers,whimboo,emilio

Comment 27

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/69e99d87df48
https://hg.mozilla.org/mozilla-central/rev/ebb4441eb500
https://hg.mozilla.org/mozilla-central/rev/eef1d8be4e7b
https://hg.mozilla.org/mozilla-central/rev/c0280f40a197

Comment 28

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1587468 - Update lucet-runtime. r=glandium,#build

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/823a7bf8c482
Update lucet-runtime.

Comment 30

[Emilio Cobos Álvarez [:emilio]]

(In reply to Pulsebot from comment #29)

https://hg.mozilla.org/integration/autoland/rev/823a7bf8c482
Update lucet-runtime.

This should've landed with r=froydnj, but apparently lando didn't peek the change in-flight...

Comment 31

[Emilio Cobos Álvarez [:emilio]]

Bug 1604120 gets rid of the last bit here.

Comment 33

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/823a7bf8c482