Update syn and quote to 1.0
Categories
(Firefox Build System :: General, task)
Tracking
(Not tracked)
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(12 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
https://hg.mozilla.org/integration/autoland/rev/713dee70307d pulls the new syn and quote versions. We should update all the crates to not duplicate the dependency.
|
Assignee | |
Comment 1•5 years ago
|
||
PRs to track:
- https://github.com/rust-lang-nursery/failure/pull/329 (for some reason we have a dependency from
failurefrom a few crates that are hard to get rid of). - https://github.com/JelteF/derive_more/ needs a release, but it's updated on trunk.
- https://github.com/bholley/malloc_size_of_derive/pull/3
- https://github.com/m4b/scroll/pull/61 (this is used by the profiler)
And then there's the workspace-hack which uses syn and quote with very concrete dependencies. I'll try to figure out what the right thing to do is there.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
This is only used by webdriver.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a1a65319a43 Update cssparser to v0.25.9. r=boris https://hg.mozilla.org/integration/autoland/rev/6e641b4a78b5 Update cssparser-macros to 0.3.6. r=boris https://hg.mozilla.org/integration/autoland/rev/d773bdf9f8e0 Update cstr-macros to v0.1.6. r=boris
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/241a2e6159b0 Update num_derive to 0.3. r=boris https://hg.mozilla.org/integration/autoland/rev/16c3040fb388 Update syn / quote / synstructure in peek-poke-derive. r=jrmuizel
|
||
Comment 10•5 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/405b9a7fec75 Add syn/quote/etc to the list of allowed duplicated WR dependencies for now. r=bustage
|
||
Comment 11•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4a1a65319a43
https://hg.mozilla.org/mozilla-central/rev/6e641b4a78b5
https://hg.mozilla.org/mozilla-central/rev/d773bdf9f8e0
https://hg.mozilla.org/mozilla-central/rev/241a2e6159b0
https://hg.mozilla.org/mozilla-central/rev/16c3040fb388
https://hg.mozilla.org/mozilla-central/rev/405b9a7fec75
|
|
||
Comment 12•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/091a5a4ec150 Update headers_derive to v0.1.1. r=ato
|
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 14•5 years ago
|
||
This removes an old version of synstructure.
|
|
Assignee | |
Comment 15•5 years ago
|
||
We are no longer using a pinned version of serde, so update to avoid the
dependency on older syn / quote / etc.
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Comment 16•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b168e040a286 Update failure_derive and malloc_size_of_derive. r=heycam
|
||
Comment 17•5 years ago
|
||
| bugherder | ||
|
|
||
Updated•5 years ago
|
|
|
||
Comment 18•5 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/285df50f96b2 Update serde and related crates. r=nical
|
||
Comment 19•5 years ago
|
||
| bugherder | ||
|
||
Comment 20•4 years ago
|
||
This has the side effect of adding another version of uuid, which we'll
upgrade for other dependencies subsequently.
|
|
||
Comment 21•4 years ago
|
||
This leaves one out-of-tree of uuid 0.7, handled by https://github.com/mozilla/rkv/pull/184
(but we have two copies of that, we'd need to have it landed on both
branches and pulled).
|
|
||
Comment 22•4 years ago
|
||
With the two patches I attached, we're down to 3 dependencies on syn < 1.0:
- one from derive_more, which emilio addressed in part with https://github.com/mozilla/neqo/commit/06df157225f4bbac5adbba98f0c6ba2644847d64 , and when that lands in-tree, we can update the other in-tree crates that use derive_more.
- one from num-derive, which I addressed in https://github.com/PLSysSec/lucet_sandbox_compiler/pull/4
- one from packed_struct_codegen, which was added in bug 1597989, and bbouvier said he wanted to remove that dependency.
I'm tempted to add a check in mach vendor rust that errors out if we add another version of syn...
|
|
Assignee | |
Comment 23•4 years ago
|
||
|
|
||
Comment 24•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69e99d87df48 Update derive_more. r=glandium
|
|
||
Comment 25•4 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/ebb4441eb500 follow-up: Update webrender's lockfile in a CLOSED TREE.
|
|
||
Comment 26•4 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/eef1d8be4e7b Update object to 0.16.0 and goblin to 0.1.2. r=emilio https://hg.mozilla.org/integration/autoland/rev/c0280f40a197 Update uuid to 0.8.1. r=webdriver-reviewers,whimboo,emilio
|
||
Comment 27•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 28•4 years ago
|
||
|
|
||
Comment 29•4 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/823a7bf8c482 Update lucet-runtime.
|
|
Assignee | |
Comment 30•4 years ago
|
||
(In reply to Pulsebot from comment #29)
https://hg.mozilla.org/integration/autoland/rev/823a7bf8c482
Update lucet-runtime.
This should've landed with r=froydnj, but apparently lando didn't peek the change in-flight...
|
|
Assignee | |
Comment 31•4 years ago
|
||
Bug 1604120 gets rid of the last bit here.
|
||
Updated•4 years ago
|
|
||
Comment 33•4 years ago
|
||
| bugherder | ||
Description
•