1587522 - [EME] Surface events to GeckoView to approve or deny MediaKeySystemAccess

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

GeckoView would like to be able to approve or deny Navigator.requestMediaKeySystemAccess(). This allows for flexibility in Apps interaction with EME. The way Gecko currently handles EME does not enable this. We'd want to do something similar to what gUM does.

Useful references:

• GeckoView permission manager.
• browser-media.js which handles some of the existing EME messages on desktop.
• MediaManager which managers the gecko side of sending notifications for gUM.
• GetUserMediaRequest which is passed around to represent a gUM request.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Bug 1593843 has done this for the autoplay side and is a good reference for how to do it using ContentPermissionRequestBase based machinery rather than JS level message managers.

My current WIP uses the message manager approach, similar to some of our existing EME and gUM code. However the ContentPermissionRequestBase based approach looks like it has benefits as it's been suggested to me it may be more robust for Fission use cases and enabling flexibility in permissions for nested contexts.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1587522 - Add media.eme.require-app-approval pref to control if EME needs app permission. r?alwu

Add a pref that we can gate the EME app approval behaviour behind. If the pref
is true we'll ask app for approval via a permission request. The intended use
for this is to allow GeckoView to seek explicit approval from the embedding app.

Having this pref is also useful for testing outside of GeckoView as it allows
runtime configuration of the permission check.

Comment 3

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1587522 - Add MediaKeySystemAccessPermissionRequest. r?alwu

This class will be used to surface permission requests to GeckoView.

Depends on D56102

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1587522 - Surface events from MediaKeySystemAccessManager to let the app wrapping gecko allow or deny EME. r?alwu

Depends on D56103

Comment 5

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1587522 - Add test for EME app approval. r?alwu

Add a test to cover app approval for EME. The test is not currently targeted at
android despite the feature being made for GeckoView. This is because we do not
have clearkey support on Android, and cannot guarantee Widevine support. If we
have broad Widevine support on Android we could rework the test to use that when
on Android.

For now having some test coverage on clearkey platforms seems better than having
no test coverage.

Depends on D56104

Comment 6

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c96c55894f86b26bcdcb979f5f0246ec811df1e

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1587522 - Use default initializer for MediaKeySystemAccessManager::mAddedObservers. r?alwu

Depends on D56104

Comment 8

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e54bb2d0a5dd530a2266383f05fe7c6c43f1b23&selectedJob=290261643

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5243ee8be876
Add media.eme.require-app-approval pref to control if EME needs app permission. r=alwu
https://hg.mozilla.org/integration/autoland/rev/a95e3da9c1b5
Add MediaKeySystemAccessPermissionRequest. r=alwu
https://hg.mozilla.org/integration/autoland/rev/f9ef7c41805c
Surface events from MediaKeySystemAccessManager to let the app wrapping gecko allow or deny EME. r=alwu
https://hg.mozilla.org/integration/autoland/rev/76602e77f731
Use default initializer for MediaKeySystemAccessManager::mAddedObservers. r=alwu
https://hg.mozilla.org/integration/autoland/rev/0bc46cd428e4
Add test for EME app approval. r=alwu

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5243ee8be876
https://hg.mozilla.org/mozilla-central/rev/a95e3da9c1b5
https://hg.mozilla.org/mozilla-central/rev/f9ef7c41805c
https://hg.mozilla.org/mozilla-central/rev/76602e77f731
https://hg.mozilla.org/mozilla-central/rev/0bc46cd428e4