1587541 - Make content scripts work in Fission iframes

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Tomislav Jovanovic :zombie]

Depends on extension messaging/ports at the very least, possibly other things.

Comment 1

[Tomislav Jovanovic :zombie]

A number of mochitests depend on it:

• browser/components/extensions/test/browser/browser_ext_contentscript_nontab_connect.js

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[Chris Peterson [:cpeterson]]

Tracking WebExtension bugs for Fission dogfooding milestone (M5).

Comment 4

[Chris Peterson [:cpeterson]]

Deferring to Fission Nightly (M6)

Comment 5

[Chris Peterson [:cpeterson]]

Tentatively moving P1 Fission M6 bugs to M6a.

Comment 6

[Tomislav Jovanovic :zombie]

Attachment: Bug 1587541 - Enable content scripts for OOP iframes in browser tabs

Comment 7

[Tomislav Jovanovic :zombie]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=599589cb90afc02d97930e1e6705d46fdbeb50a9

This is only the first part, doesn't handle iframes in sidebars and popups, but I want to land the most useful part and enable further testing.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f98a9b6a424b
Enable content scripts for OOP iframes in browser tabs r=robwu

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f98a9b6a424b

Comment 10

[Tomislav Jovanovic :zombie]

This was just one part, I forgot to add leave-open.

Comment 11

[Tomislav Jovanovic :zombie]

Attachment: Bug 1587541 - Make tab.executeScript, insertCSS, removeCSS Fission compatible

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60840d7cfef1
Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl

Comment 13

[Narcis Beleuzu [:NarcisB]]

Backed out for Documentation opt failure

Backout link: https://hg.mozilla.org/integration/autoland/rev/ccb87a635c596be630a9b6f552649fff85db1693
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309515915&repo=autoland&lineNumber=1022

Comment 14

[Narcis Beleuzu [:NarcisB]]

Please also check failures on /test_chrome_ext_contentscript_telemetry.html -> https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309517005&repo=autoland&lineNumber=11893

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeaa527e6119
Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl

Comment 16

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_chrome_ext_contentscript_telemetry.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/9a24ba7aab535843951830d1be95494522dd3a53
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309536669&repo=autoland&lineNumber=11623

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/328b97bc228e
Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/328b97bc228e

Comment 19

[Andreea Pavel [:apavel]]

Backed out for causing bug 1652665
Backout link: https://hg.mozilla.org/mozilla-central/rev/81408f083877ec003ab6edd2b1a02ef7573ecd7b

Comment 20

[Tomislav Jovanovic :zombie]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f006c2d00d3eec864c192a63fa4c1fa0464f6ce

Comment 21

[Tomislav Jovanovic :zombie]

Attachment: Bug 1587541 - Change ContentScript::MatchesWindow to operate on WindowGlobals directly

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f53c5ecd471
Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98f8b96a4aee
Change ContentScript::MatchesWindow to operate on WindowGlobals directly r=kmag

Comment 24

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8f53c5ecd471
https://hg.mozilla.org/mozilla-central/rev/98f8b96a4aee

Comment 25

[Tomislav Jovanovic :zombie]

Hi Vlad, can you please verify that bug 1652665 is not happening with the latest Nightly?

Comment 27

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

I can no longer reproduce 1652665. Verified using Win10x64, macOS 10.15.6 and Ubuntu 18.04x64 80.0a1(20200717093907)

Comment 28

[Tomislav Jovanovic :zombie]

Thanks Vlad.