1587552 - Allow removing a content blocking exception in GV by URI

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Dylan Roeh (:droeh) (he/him)]

A major pain point in the current content blocking exceptions GV API is that Fenix would like to support displaying all existing exceptions and allowing the user to remove them individually. Since removeException currently takes a GeckoSession, this requires a pretty ugly workaround. We should investigate overloading removeException to take a uri instead to facilitate this use case.

Comment 1

[Emily Toop (:fluffyemily)]

Waiting to hear from Fenix whether the feature stays or goes.

Comment 2

[vzare]

This is a high priority for Fenix. What is the effort for this work?

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1587552 - Update GeckoView content blocking exception API and add better support for removing exceptions. r=esawin!,ehsan!,#geckoview-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db42fce46a0b
Update GeckoView content blocking exception API and add better support for removing exceptions. r=esawin,Ehsan,geckoview-reviewers,snorp

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for gv failures on trackingProtectionExceptionRemoveByException.

Backout link: https://hg.mozilla.org/integration/autoland/rev/12d8255184b1015ff34f35c6fb040bbde6be2ed3
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284874380&repo=autoland&lineNumber=1480

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1eaffa34ee7
Update GeckoView content blocking exception API and add better support for removing exceptions. r=esawin,Ehsan,geckoview-reviewers,snorp

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b1eaffa34ee7

Comment 8

[Chris Peterson [:cpeterson]]

Move GeckoView::Tracking Protection bugs to the GeckoView::General component.