1587564 - [meta] Improve use of BytecodeLocationOffset class in bytecode interface implementation

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, enhancement, P3)

Description

[Adam Holm]

Right now BytecodeLocationOffset is underused in implementations of the bytecode interface with classes BytecodeLocation and BytecodeIterator. Implementing the bytecode interface can lead to some awkward offset value calculations with uint32_t variables. Possibly BytecodeLocationOffset could be integrated with BytecodeLocation so as to provide offset accessors?

I'm making this a meta bug because I suspect this may involve many bugs.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:sdetar, maybe it's time to close this bug?

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

This should definitely hang around; it does need some TLC

Comment 3

[Adam Holm]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #2)

This should definitely hang around; it does need some TLC

What sort of TLC?

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Mostly we need to have some seed child issues figured out; someone will have to pathfind to make sure that BytecodeOffset has the right interface and works as expected, with the correct checks in the correct places etc. The best way to do that will be having some preliminary targets.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:sdetar, maybe it's time to close this bug?

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

I'd like this kept open until I, or someone else, can bring some effort to evaluate the status.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:sdetar, maybe it's time to close this bug?

Comment 8

[Steven DeTar [:sdetar]]

Matthew, do you still want to keep this bug open?

Comment 9

[Matthew Gaudet (he/him) [:mgaudet]]

Let's close this for now.