Closed Bug 1587622 Opened Last month Closed 27 days ago

Use MOZ_ASSERT_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM code

Categories

(Core :: DOM: Core & HTML, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Regression)

Details

Attachments

(1 file)

When updating double-conversion in bug 1587590, I noticed that there are two instances in DOM code of double-conversion's UNREACHABLE macro being used in random DOM code instead of MFBT's MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE instead.

Regressed by: 1542674
Attachment #9100254 - Attachment description: Bug 1587622 - Use MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM media code. r=karlt → Bug 1587622 - Use MOZ_ASSERT_UNREACHABLE() instead of double-conversion's UNREACHABLE() in DOM media code. r=karlt
Summary: Use MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM code → Use MOZ_ASSERT_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM code
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd3e04ade52a
Use MOZ_ASSERT_UNREACHABLE() instead of double-conversion's UNREACHABLE() in DOM media code. r=karlt
Status: NEW → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.