Closed
Bug 1587622
Opened 5 years ago
Closed 5 years ago
Use MOZ_ASSERT_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM code
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
When updating double-conversion in bug 1587590, I noticed that there are two instances in DOM code of double-conversion's UNREACHABLE macro being used in random DOM code instead of MFBT's MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE instead.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Keywords: regression
Updated•5 years ago
|
Attachment #9100254 -
Attachment description: Bug 1587622 - Use MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM media code. r=karlt → Bug 1587622 - Use MOZ_ASSERT_UNREACHABLE() instead of double-conversion's UNREACHABLE() in DOM media code. r=karlt
Assignee | ||
Updated•5 years ago
|
Summary: Use MOZ_MAKE_COMPILER_ASSUME_IS_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM code → Use MOZ_ASSERT_UNREACHABLE instead of double-conversion's UNREACHABLE in DOM code
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd3e04ade52a Use MOZ_ASSERT_UNREACHABLE() instead of double-conversion's UNREACHABLE() in DOM media code. r=karlt
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•