Closed Bug 1587633 Opened 5 years ago Closed 5 years ago

Move test_web_accessible_resources_csp to an xpcshell test

Categories

(WebExtensions :: General, defect, P2)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: zombie, Assigned: zombie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1587633 - Move test_web_accessible_resources_csp to an xpcshell test
47 bytes, text/x-phabricator-request
Details | Review

It's hard to do what that test is doing from a plain mochitest in a fission-compatible way.

Other options are moving it to a browser mochitest (and using BTU), but xpcshell seems more appropriate, even if it wouldn't currently be testing with fission.

Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0274289bd7b8
Move test_web_accessible_resources_csp to an xpcshell test r=robwu

Backed out changeset 0274289bd7b8 (bug 1587633) for build bustage

Backout: https://hg.mozilla.org/integration/autoland/rev/73996ecc9e93e9085ee6702cb2bc4abc5c5d8d78

Failure push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0274289bd7b84a450b5dba6c676b64dfd2232302

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270678148&repo=autoland&lineNumber=43955

[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
[task 2019-10-10T13:33:47.519Z] 13:33:47 ERROR - package-tests> Traceback (most recent call last):
[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> "main", fname, loader, pkg_name)
[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> exec code in run_globals
[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 114, in <module>
[task 2019-10-10T13:33:47.519Z] 13:33:47 INFO - package-tests> main(sys.argv[1:])
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 100, in main
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> defines=args.defines)
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 69, in process_manifest
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> remove_empty_directories=remove_empty_directories)
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/copier.py", line 432, in copy
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> copy_results.append((destfile, f.copy(destfile, skip_if_older)))
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/files.py", line 364, in copy
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> raise ErrorMessage('Symlink target path does not exist: %s' % self.path)
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> mozpack.errors.ErrorMessage: Symlink target path does not exist: /builds/worker/workspace/build/src/toolkit/components/extensions/test/mochitest/file_csp.html
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> Makefile:122: recipe for target 'install-test-files' failed
[task 2019-10-10T13:33:47.520Z] 13:33:47 ERROR - package-tests> make[2]: *** [install-test-files] Error 1
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2019-10-10T13:33:47.520Z] 13:33:47 INFO - package-tests> make[2]: *** Waiting for unfinished jobs....
[task 2019-10-10T13:34:09.680Z] 13:34:09 INFO - package> make[5]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/browser/installer'
[task 2019-10-10T13:34:09.680Z] 13:34:09 INFO - package> NO_PKG_FILES="core bsdecho js js-config jscpucfg nsinstall viewer TestGtkEmbed elf-dynstr-gc mangle* maptsv* mfc* msdump* msmap* nm2tsv* nsinstall* res/samples res/throbber shlibsign* certutil* pk12util* BadCertAndPinningServer* DelegatedCredentialsServer* OCSPStaplingServer* SanctionsTestServer* GenerateOCSPResponse* chrome/chrome.rdf chrome/app-chrome.manifest chrome/overlayinfo components/compreg.dat components/xpti.dat content_unit_tests necko_unit_tests *.dSYM SmokeDMD"
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.py -DPKG_LOCALE_MANIFEST=/builds/worker/workspace/build/src/obj-firefox/browser/installer/locale-manifest.in -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DMOZ_DEBUG=1 -DMOZ_LAYOUT_DEBUGGER=1 -DMOZ_GTK=1 -DJAREXT= -DMOZ_ENABLE_SKIA_PDF=1 -DMOZ_CHILD_PROCESS_NAME=plugin-container -DNECKO_WIFI -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DDIR_MACOS= -DDIR_RESOURCES= -DBINPATH='bin' -DRESPATH='bin' -DLPROJ_ROOT=en -DCLANG_CXX -DENABLE_MARIONETTE=1 -DA11Y_LOG=1 -DACCESSIBILITY=1 -DATK_MAJOR_VERSION=2 -DATK_MINOR_VERSION=8 -DATK_REV_VERSION=0 -DBROWSER_CHROME_URL=chrome://browser/content/browser.xhtml -DBROWSER_CHROME_URL_QUOTED='"chrome://browser/content/browser.xhtml"' -DBUILD_CTYPES=1 -DCROSS_COMPILE=1 -DEARLY_BETA_OR_EARLIER=1 -DENABLE_INTL_API=1 -DENABLE_REMOTE_AGENT=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DENABLE_TYPED_OBJECTS=1 -DENABLE_WASM_BIGINT=1 -DENABLE_WASM_BULKMEM_OPS=1 -DENABLE_WASM_CRANELIFT=1 -DENABLE_WASM_GC=1 -DENABLE_WASM_REFTYPES=1 -DFORCE_PR_LOG=1 -DFUNCPROTO=15 -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_4 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_PROVIDER_EGL=1 -DGTEST_HAS_RTTI=0 -DHAVE_ALLOCA_H=1 -DHAVE_BYTESWAP_H=1 -DHAVE_CLOCK_MONOTONIC=1 -DHAVE_CPUID_H=1 -DHAVE_DIRENT_H=1 -DHAVE_DLADDR=1 -DHAVE_DLOPEN=1 -DHAVE_FONTCONFIG_FCFREETYPE_H=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_GETOPT_H=1 -DHAVE_GMTIME_R=1 -DHAVE_INTTYPES_H=1 -DHAVE_LCHOWN=1 -DHAVE_LINUX_IF_ADDR_H=1 -DHAVE_LINUX_PERF_EVENT_H=1 -DHAVE_LINUX_QUOTA_H=1 -DHAVE_LINUX_RTNETLINK_H=1 -DHAVE_LOCALECONV=1 -DHAVE_LOCALTIME_R=1 -DHAVE_LSTAT64=1 -DHAVE_MALLINFO=1 -DHAVE_MALLOC_H=1 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MEMALIGN=1 -DHAVE_MEMMEM=1 -DHAVE_NETINET_IN_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_POSIX_FALLOCATE=1 -DHAVE_POSIX_MEMALIGN=1 -DHAVE_PTHREAD_H=1 -DHAVE_RES_NINIT=1 -DHAVE_SETPRIORITY=1 -DHAVE_STAT64=1 -DHAVE_STDINT_H=1 -DHAVE_STRERROR=1 -DHAVE_STRNDUP=1 -DHAVE_SYSCALL=1 -DHAVE_SYS_QUEUE_H=1 -DHAVE_SYS_QUOTA_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DHAVE_TRUNCATE64=1 -DHAVE_UNISTD_H=1 -DHAVE_VALLOC=1 -DHAVE_VA_COPY=1 -DHAVE_VISIBILITY_ATTRIBUTE=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DHAVE__UNWIND_BACKTRACE=1 -DHAVE___CXA_DEMANGLE=1 -DJS_BUILD_BINAST=1 -DJS_CODEGEN_X86=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_GC_ZEAL=1 -DJS_JITSPEW=1 -DJS_MASM_VERBOSE=1 -DJS_NUNBOX32=1 -DJS_STRUCTURED_SPEW=1 -DJS_TRACE_LOGGING=1 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR='' -DMOZILLA_OFFICIAL=1 -DMOZILLA_UAVERSION='"71.0"' -DMOZILLA_VERSION='"71.0a1"' -DMOZILLA_VERSION_U=71.0a1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZ_ALLOW_LEGACY_EXTENSIONS=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"71.0a1"' -DMOZ_AV1=1 -DMOZ_BLOCK_PROFILE_DOWNGRADE=1 -DMOZ_BUILD_APP=browser -DMOZ_BUNDLED_FONTS=1 -DMOZ_CLANG_PLUGIN=1 -DMOZ_CRASHREPORTER=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DAV1D_ASM=1 -DMOZ_DEBUG=1 -DMOZ_DEBUG_RUST=1 -DMOZ_DEDICATED_PROFILES=1 -DMOZ_DEMANGLE_SYMBOLS=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_DLL_PREFIX='"lib"' -DMOZ_DLL_SUFFIX='".so"' -DMOZ_DMD=1 -DMOZ_DUMP_PAINTING=1 -DMOZ_ENABLE_DBUS=1 -DMOZ_ENABLE_SKIA=1 -DMOZ_ENABLE_SKIA_PDF=1 -DMOZ_ENABLE_SKIA_PDF_SFNTLY=1 -DMOZ_FFMPEG=1 -DMOZ_FFVPX=1 -DMOZ_FFVPX_AUDIOONLY=1 -DMOZ_FMP4=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GECKO_PROFILER_PARSE_ELF=1 -DMOZ_GLUE_IN_PROGRAM=1 -DMOZ_HAS_REMOTE=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.nightlydebug -DMOZ_MEMORY=1 -DMOZ_NEW_CERT_STORAGE=1 -DMOZ_NEW_NOTIFICATION_STORE=1 -DMOZ_NEW_XULSTORE=1 -DMOZ_NORMANDY=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PHOENIX=1 -DMOZ_PLACES=1 -DMOZ_PROFILER_MEMORY=1 -DMOZ_PROFILING=1 -DMOZ_PULSEAUDIO=1 -DMOZ_RAW=1 -DMOZ_REFLOW_PERF=1 -DMOZ_REFLOW_PERF_DSP=1 -DMOZ_REPLACE_MALLOC=1 -DMOZ_RUST_SIMD=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SANDBOX=1 -DMOZ_SCTP=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_TELEMETRY_ON_BY_DEFAULT=1 -DMOZ_TELEMETRY_REPORTING=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_USER_DIR='".mozilla"' -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_VORBIS=1 -DMOZ_VTUNE=1 -DMOZ_WAYLAND=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WIDGET_GTK=1 -DMOZ_X11=1 -DMOZ_XBL=1 -DMOZ_XUL=1 -DNIGHTLY_BUILD=1 -DNO_NSPR_10_SUPPORT=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"x86-gcc3"' -DUSE_SKIA=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVA_COPY=va_copy -DWASM_CODEGEN_DEBUG=1 -DWASM_PRIVATE_REFTYPES=1 -DXP_LINUX=1 -DXP_UNIX=1 -D_REENTRANT=1 -DAB_CD=en-US
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> --format omni
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> --removals /builds/worker/workspace/build/src/browser/installer/removed-files.in
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package>
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package>
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> --minify
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package>
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package>
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> --compress none
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> /builds/worker/workspace/build/src/browser/installer/package-manifest.in '../../dist' '../../dist'/firefox
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package>
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> ../../dist/firefox/libnspr4.so: No gain. Skipping
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> ../../dist/firefox/libplc4.so: No gain. Skipping
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> ../../dist/firefox/libplds4.so: Couldn't find .bss. Skipping
[task 2019-10-10T13:34:09.684Z] 13:34:09 INFO - package> ../../dist/firefox/libxul.so: Reduced by 2322256 bytes
[task 2019-10-10T13:34:09.685Z] 13:34:09 INFO - package> ../../dist/firefox/libmozgtk.so: Couldn't find .bss. Skipping
[task 2019-10-10T13:34:09.685Z] 13:34:09 INFO - package> ../../dist/firefox/gtk2/libmozgtk.so: Couldn't find .bss. Skipping
[task 2019-10-10T13:34:09.685Z] 13:34:09 INFO - package> ../../dist/firefox/libmozwayland.so: No gain. Skipping
[task 2019-10-10T13:34:09.685Z] 13:34:09 INFO - package> ../../dist/firefox/libmozsqlite3.so: Reduced by 12140 bytes
[task 2019-10-10T13:34:09.685Z] 13:34:09 INFO - package> ../../dist/firefox/liblgpllibs.so: No gain. Skipping

Flags: needinfo?(tomica)
Flags: needinfo?(tomica)
No longer depends on: 1587221
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dca541990a2
Move test_web_accessible_resources_csp to an xpcshell test r=robwu

https://hg.mozilla.org/mozilla-central/rev/1dca541990a2

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(tomica)
Flags: needinfo?(tomica) → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: