Closed
Bug 1587678
Opened 5 years ago
Closed 5 years ago
[BinAST] Use simpler container than Vector when fixed-size
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(3 files)
most Vector
used in context reader is fixed-size (on runtime, not compile-time).
Vector
would be overkill and we can use simpler one, so that it takes less space.
Allocator in bug 1587271 can be used, or maybe we can just use LifoAlloc
.
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D49562
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D49563
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D49564
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/075094902160 Part 1: Add FixedLengthVector. r=Yoric https://hg.mozilla.org/integration/autoland/rev/16e2bc05dda0 Part 2: Use FixedLengthVector when the size is known at the allocation. r=Yoric https://hg.mozilla.org/integration/autoland/rev/00eab2270961 Part 3: Remove unnecessary JSContext* parameter. r=Yoric
Comment 5•5 years ago
|
||
Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=272181996&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=272181899&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/31f16b9b58630abad5477ecf1c112af7218c324d
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/8b017b6a20f4 Part 1: Add FixedLengthVector. r=Yoric https://hg.mozilla.org/integration/autoland/rev/9d6fc4af400d Part 2: Use FixedLengthVector when the size is known at the allocation. r=Yoric https://hg.mozilla.org/integration/autoland/rev/141755ff04e1 Part 3: Remove unnecessary JSContext* parameter. r=Yoric
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8b017b6a20f4
https://hg.mozilla.org/mozilla-central/rev/9d6fc4af400d
https://hg.mozilla.org/mozilla-central/rev/141755ff04e1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(arai.unmht)
You need to log in
before you can comment on or make changes to this bug.
Description
•