1587678 - [BinAST] Use simpler container than Vector when fixed-size

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

most Vector used in context reader is fixed-size (on runtime, not compile-time).
Vector would be overkill and we can use simpler one, so that it takes less space.

Allocator in bug 1587271 can be used, or maybe we can just use LifoAlloc.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1587678 - Part 1: Add FixedLengthVector. r?Yoric

Depends on D49562

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1587678 - Part 2: Use FixedLengthVector when the size is known at the allocation. r?Yoric

Depends on D49563

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1587678 - Part 3: Remove unnecessary JSContext* parameter. r?Yoric

Depends on D49564

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/075094902160
Part 1: Add FixedLengthVector. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/16e2bc05dda0
Part 2: Use FixedLengthVector when the size is known at the allocation. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/00eab2270961
Part 3: Remove unnecessary JSContext* parameter. r=Yoric

Comment 5

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=00eab227096178b7d95e0a375cb25a300095219b&selectedJob=272181996

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=272181996&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=272181899&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/31f16b9b58630abad5477ecf1c112af7218c324d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b017b6a20f4
Part 1: Add FixedLengthVector. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/9d6fc4af400d
Part 2: Use FixedLengthVector when the size is known at the allocation. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/141755ff04e1
Part 3: Remove unnecessary JSContext* parameter. r=Yoric

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8b017b6a20f4
https://hg.mozilla.org/mozilla-central/rev/9d6fc4af400d
https://hg.mozilla.org/mozilla-central/rev/141755ff04e1