1587741 - Captive Portal Service should use a new detector when we start again

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

If the captive portal service is disabled then enabled again when in a captive portal, we sometimes don't send the captive-portal-login observer notification because we're reusing the same mCaptiveDetector object, which believes it's already sent it.
We should use do_CreateInstance instead of do_GetService for this.

I have a testcase that triggers this in test_trr.js in bug 1552176, but I haven't managed to reduce it yet.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1587741 - Captive Portal Service should use a new detector when we start again r=mayhemer

If the captive portal service is disabled then enabled again when in a captive
portal, we sometimes don't send the captive-portal-login observer notification
because we're reusing the same mCaptiveDetector object, which believes it's
already sent it.

We should use do_CreateInstance instead of do_GetService for this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b085b41c10ce
Captive Portal Service should use a new detector when we start again r=mayhemer

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b085b41c10ce