1587769 - Changing the device name doesn't cause an immediate sync

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect, P2)

Description

[Vasilica Tamas, QA [:vtamas]]

[Affected versions]:
Firefox 71.0a1 (2019-10-09)

Affected platforms:
Windows 10 x64
Mac OS X 10.14.6

Steps to reproduce:
1.Connect on 2 devices with a Firefox account
2.Ensure sync is turned ON
3.Change the name of one of the devices and perform a sync.
4.Perform a sync on the second device and check in Synced Tabs list the name of the first device.

Expected Results:
The name of the first device is successfully updated.

Actual Results:
The name of the first device is not synced.

[Additional Notes]:
This issue was regressed by: Bug 1575921 (https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5c3f179b532f7ebbea4c49b7deac59b4929b3363&tochange=ed89fc2a60d8b902735a862da57631b8a5eb2aa6)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Thanks! The issue here is that we weren't forcing a "sync now" as the name changed, which we definitely should - so while it was synced, it wasn't synced as soon as it should be.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1587769 - update the pref we watch to ensure we sync immediately after device name change. r?eoger

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b283ff7809b
update the pref we watch to ensure we sync immediately after device name change. r=eoger

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8b283ff7809b

Comment 5

[Miruna Curtean]

Verified fixed with account on Windows pro 10 64-bit and on macOS Catalina 10.15 on FF 71.0b5 (20191028110005) and 72.0a1 (20191031194708)
Immediately after modifying the device name on the first device I've checked the Synced Tabs on the second device where a sync now occurs as you enter the panel and the name of the first device is updated correctly.
On a side note, the device name is also updated correctly after a status refresh in the Device &apps section of the Manage account if the user is already there.