Closed Bug 1587781 Opened 5 years ago Closed 5 years ago

Menu on blocked resource always shows "unblock"

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox71 verified)

VERIFIED FIXED
Firefox 71
Tracking Status
firefox71 --- verified

People

(Reporter: Harald, Assigned: davidwalsh)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image image.png

STR:

  • Block a resource by pattern, like style.css
  • Refresh
  • Hit Unblock menu on the blocked resource
  • Open the context menu again on the same resource

AR: Unblock remains

ER: Block shows

Good catch. From a functionality perspective the unblock works because, in this case, it should keep the pattern but disable the checkbox, which it does.

The core issue is that hasMatchingBlockingRequestPattern only receives a list of URLs, and not whether they are disabled or enabled. We need to broaden that line of functionality to only include the enabled blocked URLs, which would make the label appear correctly.

Attachment #9100189 - Attachment description: Bug 1587781 - Display correct context menu item for blocking URLs → Bug 1587781 - Display correct context menu item for blocking URLs r=honza
Assignee: nobody → dwalsh
Status: NEW → ASSIGNED
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9307e73941a7
Display correct context menu item for blocking URLs r=Honza
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Confirmed issue with 71.0a1 (2019-10-10) on Windows 10.
Verified fix with 71.0a1 (2019-10-21) .

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: