Closed Bug 1587817 Opened 5 months ago Closed 4 months ago

Opening a PB window and clicking Home loads about:newtab, that uses the wrong engine

Categories

(Firefox :: Search, defect, P2)

defect
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 71
Iteration:
71.4 - Oct 14 - 20
Tracking Status
firefox71 --- fixed

People

(Reporter: mak, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

about:newtab is usually not presented in PB windows, but one can click on the Home button, and load it easily, it's not so strange.
The AS code and contentSeatch don't handle a separate private engine for now.

Bug 1576158 may have helped here? Must be verified.

See Also: → 1576158
Priority: P3 → P2

I can have a look at this, hopefully it's not crazy.

Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 71.3 - Sept 30 - Oct 13
Points: 5 → 3
Iteration: 71.3 - Sept 30 - Oct 13 → 71.4 - Oct 14 - 20

Just discussed with Marco, and I'm going to take this up.

Assignee: mak77 → standard8

This reverts part of bug 1576158 and uses RPMIsWindowPrivate instead as that provides the necessary information in a better way (the various activity manager components don't seem to have easy access to the window object).

Taking over from Mark, as per our conversation on Zoom today. We both agreed on the right approach to take here.

Assignee: standard8 → mdeboer
Attachment #9100890 - Attachment is obsolete: true

Mike, I just wanted to check if there's anything I need to do to coordinate with you on this with my patch in bug 1529969 (which adds a new ContentSearchHandoffUIController for when search handoff is enabled). I can wait for this to land or get my patch landed first; whichever you think makes more sense.

Flags: needinfo?(mdeboer)

This reverts part of bug 1576158, so that all current and future in-content pages share the same implementation.

Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f10a00c6671
Move the default search engine in Private Browsing mode for in-content search access points to be contained in ContentSearch.jsm. r=Mardak,Standard8
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

(In reply to Jim Porter (:squib) from comment #6)

Mike, I just wanted to check if there's anything I need to do to coordinate with you on this with my patch in bug 1529969 (which adds a new ContentSearchHandoffUIController for when search handoff is enabled). I can wait for this to land or get my patch landed first; whichever you think makes more sense.

Sorry we didn't get back to you earlier. This has now landed, so you should be clear to proceed.

Flags: needinfo?(mdeboer)
You need to log in before you can comment on or make changes to this bug.