1587817 - Opening a PB window and clicking Home loads about:newtab, that uses the wrong engine

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Marco Bonardo [:mak]]

about:newtab is usually not presented in PB windows, but one can click on the Home button, and load it easily, it's not so strange.
The AS code and contentSeatch don't handle a separate private engine for now.

Comment 1

[Marco Bonardo [:mak]]

Bug 1576158 may have helped here? Must be verified.

Comment 2

[Marco Bonardo [:mak]]

I can have a look at this, hopefully it's not crazy.

Comment 3

[Mark Banner (:standard8)]

Just discussed with Marco, and I'm going to take this up.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1587817 - Allow about:newtab to detect when it is loaded in a private browsing context, not just permanent PB. r?mardak,johannh

This reverts part of bug 1576158 and uses RPMIsWindowPrivate instead as that provides the necessary information in a better way (the various activity manager components don't seem to have easy access to the window object).

Comment 5

[Mike de Boer [:mikedeboer]]

Taking over from Mark, as per our conversation on Zoom today. We both agreed on the right approach to take here.

Comment 6

[Jim Porter (:squib)]

Mike, I just wanted to check if there's anything I need to do to coordinate with you on this with my patch in bug 1529969 (which adds a new ContentSearchHandoffUIController for when search handoff is enabled). I can wait for this to land or get my patch landed first; whichever you think makes more sense.

Comment 7

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1587817 - Move the default search engine in Private Browsing mode for in-content search access points to be contained in ContentSearch.jsm. r?Mardak!,Standard8!

This reverts part of bug 1576158, so that all current and future in-content pages share the same implementation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f10a00c6671
Move the default search engine in Private Browsing mode for in-content search access points to be contained in ContentSearch.jsm. r=Mardak,Standard8

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/7f10a00c6671

Comment 10

[Mark Banner (:standard8)]

(In reply to Jim Porter (:squib) from comment #6)

Mike, I just wanted to check if there's anything I need to do to coordinate with you on this with my patch in bug 1529969 (which adds a new ContentSearchHandoffUIController for when search handoff is enabled). I can wait for this to land or get my patch landed first; whichever you think makes more sense.

Sorry we didn't get back to you earlier. This has now landed, so you should be clear to proceed.

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

Issue no longer occurs in Firefox 106.0a1 or latest Firefox 105.0.
Design has changed and also having different search engines for PBM doesn't trigger the issue.