Closed
Bug 1587955
Opened 5 years ago
Closed 5 years ago
Factor out DelazifyCanonicalScriptedFunction
Categories
(Core :: JavaScript Engine, task, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(3 files)
The current JSFunction::createScriptForLazilyInterpretedFunction is very complex and mixes several concerns. These patches factor out a DelazifyCanonincalScriptFunction helper. In the future this will transform to delazifying a script in place once LazyScript/JSScript unify. The various non-canonical cases should become greatly simplified in this world too.
|
Assignee | |
Comment 1•5 years ago
|
||
Factor out the compilation of LazyScript -> JSScript from the rest of
the cases that JSFunction::getOrCreate must handle. Semantics should be
unchanged.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D48907
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/175d4c9db7d1
Move canRelazify check to LazyScript. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/198c8c3072f3
Factor out DelazifyCanonicalScriptedFunction. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/359de86c0c10
Cleanups in DelazifyCanonicalScriptedFunction. r=mgaudet
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/175d4c9db7d1
https://hg.mozilla.org/mozilla-central/rev/198c8c3072f3
https://hg.mozilla.org/mozilla-central/rev/359de86c0c10
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•