Closed Bug 1587985 Opened Last month Closed Last month

Extend expiry of accessibility panel telemetry to never.

Categories

(DevTools :: Accessibility Tools, task)

task
Not set

Tracking

(firefox70 wontfix, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(2 files)

The accessibility panel telemetry expires in Firefox 70. It was originally added for a shield study and consequently for monitoring uptake of the tool in non-release channels (primarily Dev Edition). As of Firefox 63, the panel is enabled as one of the default developer tools (leaving us only 2 versions to see the uptake and other feature usage). After extending it previously from 65 to 70 there is no plan of removing the probes and I would like to change them to never expire.

Attachment #9101577 - Flags: data-review?(francois)
Comment on attachment 9101577 [details]
Request for data collection review form

Yura, I'm not a data steward anymore so you'll need to pick someone from the list at https://wiki.mozilla.org/Firefox/Data_Collection.
Attachment #9101577 - Flags: data-review?(francois)

(In reply to François Marier [:francois] from comment #3)

Comment on attachment 9101577 [details]
Request for data collection review form

Yura, I'm not a data steward anymore so you'll need to pick someone from the
list at https://wiki.mozilla.org/Firefox/Data_Collection.

Ah thanks, sorry !

Attachment #9101576 - Attachment description: Bug 1587985 - extend accessibility panel telemetry probes to never. r?francois, data-review=francois → Bug 1587985 - extend accessibility panel telemetry probes to never. r?chutten, data-review=chutten
Attachment #9101577 - Flags: data-review?(chutten)
See Also: → 1589252
Comment on attachment 9101577 [details]
Request for data collection review form

PRELIMINARY NOTES:

For future data reviews please include the text of the data review request as an attachment.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions files [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :yzen is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+
Attachment #9101577 - Flags: data-review?(chutten) → data-review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f3289c5e437b
extend accessibility panel telemetry probes to never. r=chutten, data-review=chutten
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9101576 [details]
Bug 1587985 - extend accessibility panel telemetry probes to never. r?chutten, data-review=chutten

Beta/Release Uplift Approval Request

  • User impact if declined: Our team never got a notification about the expiring scalars and now we are risking of not having telemetry for Firefox 70 for accessibility panel. It's especially tragic because we have a lot of new features coming out this release.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simply updating expiry values for telemetry probes.
  • String changes made/needed: None
Attachment #9101576 - Flags: approval-mozilla-beta?

Yura, you are requesting an uplift to beta has been on 71 since October 14. Your patch in comment #7 landed in 71 nightly during the soft code freeze week and got uplifted to 71 beta on the final merge day on October 22. Do I understand correctly you mean to request an uplift to the 70 release branch for the next 70 dot release? Thanks

CCing Liz who is the release owner for 70.

Flags: needinfo?(yzenevich)

(In reply to Pascal Chevrel:pascalc from comment #9)

Yura, you are requesting an uplift to beta has been on 71 since October 14. Your patch in comment #7 landed in 71 nightly during the soft code freeze week and got uplifted to 71 beta on the final merge day on October 22. Do I understand correctly you mean to request an uplift to the 70 release branch for the next 70 dot release? Thanks

CCing Liz who is the release owner for 70.

Yes ideally, if it's considered low risk it would be best to re-instate the telemetry for 70 with this patch. Thanks

Flags: needinfo?(yzenevich)
Attachment #9101576 - Flags: approval-mozilla-beta? → approval-mozilla-release?

Pascal, just to confirm, I would also have to request the same uplift to beta as well to ensure that data is reported on all channels?

Flags: needinfo?(pascalc)

(In reply to Yura Zenevich [:yzen] from comment #11)

Pascal, just to confirm, I would also have to request the same uplift to beta as well to ensure that data is reported on all channels?

If you want this probe on beta (71), yes you need to also request it for beta. Note that you you should make sure that your patch applies cleanly to all the branches you request. If you need separate patches per channel then you have to make separate uplift requests.

Flags: needinfo?(pascalc)

Can this wait for 71?

Flags: needinfo?(yzenevich)

(In reply to Liz Henry (:lizzard) from comment #13)

Can this wait for 71?

I guess it could, it's not in any way critical, we just wont have release telemetry for 70.

Flags: needinfo?(yzenevich)

If that's the way to go, then we could just flip the flag to approval-mozilla-beta?

Comment on attachment 9101576 [details]
Bug 1587985 - extend accessibility panel telemetry probes to never. r?chutten, data-review=chutten

Changed uplift flag target to beta.

Attachment #9101576 - Flags: approval-mozilla-release? → approval-mozilla-beta?

Comment on attachment 9101576 [details]
Bug 1587985 - extend accessibility panel telemetry probes to never. r?chutten, data-review=chutten

Low risk telemetry probe expiry change, uplift approved for 71 beta 6, thanks.

Attachment #9101576 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.